FS#65717 - [libatasmart] Fix Bug #97446, upstream dead for 8 years.

Attached to Project: Arch Linux
Opened by corecontingency (corecontingency) - Thursday, 05 March 2020, 23:05 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:16 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Balló György (City-busz)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:

Upstream has been dead for 8 years, since 2012.

Here's the bug:
https://bugs.freedesktop.org/show_bug.cgi?id=97446

Here's the patch:
https://bugs.freedesktop.org/attachment.cgi?id=125967


This bug causes incorrect temperature readings on some SSDs, making it permanently display a reading of 99 degrees C.

This has wide ranging effects for most temperature monitoring software since this library is used to read disk temps.

Several other upstream bugs have been fixed with Arch downstream patches (#61998, and #25772), so I don't think this bug should be an exception.

Thank you!


Here is some further discussion on the ubuntu bug report:
https://bugs.launchpad.net/ubuntu/+source/libatasmart/+bug/1581594
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:16 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/libatasmart/issues/1
Comment by Eli Schwartz (eschwartz) - Thursday, 05 March 2020, 23:18 GMT
If you follow the link to the Ubuntu bug, there's debate about whether this is the correct solution. Which of the competing patches do you think we should use...

Maybe you could get in contact with the author, who is still very active in other projects even if not for this? ;)
Comment by Balló György (City-busz) - Wednesday, 31 May 2023, 10:11 GMT
This patch may break the implementation for other disks, so we can't apply it. This should be implemented as a hardware-specific quirk, but we can't do that at distribution level. Since upstream is dead, we cannot do anything. udisks/libblockdev will be ported to smartmontools[1], other dependent projects should be ported too.

[1] https://github.com/storaged-project/libblockdev/issues/823
Comment by loqs (loqs) - Wednesday, 31 May 2023, 13:46 GMT
> other dependent projects should be ported too.
mate-sensors-applet dropped use of libatasmart [1][2]. sensors-applet is a dead project though as mate-sensors-applet was forked from it the same commits can be ported across with adjustment and at least the result builds.

[1] https://github.com/mate-desktop/mate-sensors-applet/commit/86b3ec83e0b236b0a1a25bcb12444a6a7ce61a25
[2] https://github.com/mate-desktop/mate-sensors-applet/commit/a7e24a66b69f02106db00e5392b68c39f5d4eb59
Comment by loqs (loqs) - Friday, 02 June 2023, 16:04 GMT
@City-busz the cherry-picks I applied to sensors-applet are in the attachment.
   test.patch (43.4 KiB)
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.
Comment by Jelle van der Waa (jelly) - Saturday, 02 September 2023, 13:32 GMT
City-busz do you mind patching sensors-applet else I'll just close this bug.

Loading...