FS#65627 - [code] Add GitHub.vscode-pull-request-github proposed API

Attached to Project: Community Packages
Opened by Johan Brandhorst (jbrandhorst) - Tuesday, 25 February 2020, 22:05 GMT
Last edited by Filipe Laíns (FFY00) - Tuesday, 14 April 2020, 11:45 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Filipe Laíns (FFY00)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Description:
The Visual Studio Code open source version does not include support for the proposed GitHub.vscode-pull-request-github API unless explicitly enabled. I think we should explicitly enable it, like we have other official APIs.

Additional info:
See https://github.com/microsoft/vscode-pull-request-github/issues/1338
This task depends upon

Closed by  Filipe Laíns (FFY00)
Tuesday, 14 April 2020, 11:45 GMT
Reason for closing:  Won't implement
Comment by Johan Brandhorst (jbrandhorst) - Tuesday, 25 February 2020, 22:17 GMT
Should be a minor change in https://git.archlinux.org/svntogit/community.git/tree/trunk/enable-proposed-apis.diff?h=packages/code, how does one contribute a fix?
Comment by Johan Brandhorst (jbrandhorst) - Tuesday, 14 April 2020, 09:46 GMT
Bump? What can I do to get this in? It's annoying to patch my installation every time.
Comment by Filipe Laíns (FFY00) - Tuesday, 14 April 2020, 11:45 GMT
Please use `--enable-proposed-api` to enable it.

We should have never been enabling proposed APIs automatically in the first place. Like I feared, enabling the proposed APIs we currently do is a gateway for users to ask for other ones. I have removed them in the repo, the next release will not include them.

Loading...