FS#65459 - ssh-add: life (-t) argument wraps

Attached to Project: Arch Linux
Opened by Modin (modin) - Tuesday, 11 February 2020, 16:09 GMT
Last edited by freswa (frederik) - Tuesday, 18 February 2020, 12:05 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Gaetan Bisson (vesath)
Bartłomiej Piotrowski (Barthalion)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

It seems that the life argument is not parsed correctly.

From discussion on IRC it seems that ssh-add.c#L722 and misc.c#L494 are good sources.

```
$ ssh-add -t 999999999999999999
Identity added: /home/modin/.ssh/id_rsa (/home/modin/.ssh/id_rsa)
Lifetime set to -1486618625 seconds
```

running Arch Linux, openssh v 8.1p1-2.

upstream: https://bugzilla.mindrot.org/show_bug.cgi?id=3119
This task depends upon

Closed by  freswa (frederik)
Tuesday, 18 February 2020, 12:05 GMT
Reason for closing:  Upstream
Additional comments about closing:  8.3
Comment by Giancarlo Razzolini (grazzolini) - Tuesday, 11 February 2020, 16:14 GMT
This popped up on #archlinux and I've asked Modin to open an upstream issue. But, I suspect that it could also have something to do with our toolchain rebuild. Because the value shouldn't wrap, based on this line of code: https://github.com/openssh/openssh-portable/blob/master/misc.c#L509, if I read it correctly.
Comment by Gaetan Bisson (vesath) - Tuesday, 11 February 2020, 18:25 GMT
Perfect. Let's see what upstream says. And if in the meantime I find another gcc I'll give it a try. Cheers.
Comment by Modin (modin) - Tuesday, 18 February 2020, 10:45 GMT
Upstream has supplied a patch to be released in 8.3.

https://bugzilla.mindrot.org/show_bug.cgi?id=3119#c2
Comment by Giancarlo Razzolini (grazzolini) - Tuesday, 18 February 2020, 10:50 GMT
@Modin

I don't see anything requiring us to backport this patch before 8.3 lands. Now that we know that this is indeed an upstream issue, can we close this bug report?
Comment by Modin (modin) - Tuesday, 18 February 2020, 11:53 GMT
Yes, I agree. Thanks for looking into it!

Loading...