FS#65445 - [light-locker] Build light-locker without upower support

Attached to Project: Community Packages
Opened by Tim Roes (timroes) - Monday, 10 February 2020, 11:52 GMT
Last edited by Maxime Gauduin (Alucryd) - Monday, 24 February 2020, 13:29 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Maxime Gauduin (Alucryd)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

Until version 1.8.0 the light-locker package was built without upower (`--without-upower`) support in it.
Since the 1.9.0 version the build system was switched to meson (https://git.archlinux.org/svntogit/community.git/commit/trunk?h=packages/light-locker&id=788828b261a6fc19b3c492da228b6b256e396ecf), but that configuration was lost, meaning light-locker now has a dependency on upower.

I think also with the new build system it should be built without upower support, as beforehand.
This task depends upon

Closed by  Maxime Gauduin (Alucryd)
Monday, 24 February 2020, 13:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  1.9.0-2
Comment by Maxime Gauduin (Alucryd) - Monday, 24 February 2020, 10:09 GMT
Any reason to warrant disabling upower ? Almost all DE's power managers depend on it so there's a good chance people already have it installed. Also upstream enables it by default, since we strive to provide vanilla packages I went ahead and left it as is in the new version.
Comment by Tim Roes (timroes) - Monday, 24 February 2020, 11:29 GMT
I think I'd see two reasons:

a) consistency with the previous builds, so it not just starting pulling in upower on systems that doesn't had it beforehand.
b) I think light-locker is especially popular on systems not using and DE, but (like in my case) pure awesome WM or i3 systems. That's actually how I figured that the dependency was added, because as long as upower is present, energy widgets will be used (i.e. on my laptop machines), but on the desktop there's no reason to use upower, so I basically use the installation of the package as an indicator whether you want energy widgets and management. But of course I could work around that, just wanted to raise it as a general topic, that most non DE users might not have upower installed on systems without a battery.

I don't have strong feelings into removing it or leaving it in, just a slight tendency to stay consistent with the previous builds, but if more people think it should be kept as a forced dependency, I won't object :-)
Comment by Maxime Gauduin (Alucryd) - Monday, 24 February 2020, 13:29 GMT
Fair enough, it seems light-locker doesn't link directly to upower, so it should be safe to list it as an optdep. Just pushed an update, you may remove upower from your system once it lands.

Loading...