FS#65265 - [dolphin-emu] provides weird files from vendored dependency

Attached to Project: Community Packages
Opened by Krzysztof Krakowiak (pix3l) - Saturday, 25 January 2020, 09:15 GMT
Last edited by Maxime Gauduin (Alucryd) - Monday, 03 February 2020, 17:03 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Jakob Gruber (schuay)
Maxime Gauduin (Alucryd)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

dolphin-emu should be build-dependant on discord-rpc-api and not provide it's headers files:
discord-rpc-api: /usr/include/discord_register.h exists in filesystem (owned by dolphin-emu)
discord-rpc-api: /usr/include/discord_rpc.h exists in filesystem (owned by dolphin-emu)

Additional info:
* package version(s)
community/dolphin-emu 1:5.0.r11530.ea9b96370d-1
* config and/or log files etc.
* link to upstream bug report, if any

Steps to reproduce:

# pacman -S discord-rpc-api
resolving dependencies...
looking for conflicting packages...

Package (1) New Version Net Change Download Size

chaotic-aur/discord-rpc-api 3.4.0-0 0,09 MiB 0,04 MiB

Total Download Size: 0,04 MiB
Total Installed Size: 0,09 MiB

:: Proceed with installation? [Y/n] y
:: Retrieving packages...
discord-rpc-api-3.4.0-0-x86_64 38,7 KiB 112 KiB/s 00:00 [###########################################################################] 100%
(1/1) checking keys in keyring [###########################################################################] 100%
(1/1) checking package integrity [###########################################################################] 100%
(1/1) loading package files [###########################################################################] 100%
(1/1) checking for file conflicts [###########################################################################] 100%
error: failed to commit transaction (conflicting files)
discord-rpc-api: /usr/include/discord_register.h exists in filesystem (owned by dolphin-emu)
discord-rpc-api: /usr/include/discord_rpc.h exists in filesystem (owned by dolphin-emu)
Errors occurred, no packages were upgraded.
This task depends upon

Closed by  Maxime Gauduin (Alucryd)
Monday, 03 February 2020, 17:03 GMT
Reason for closing:  Fixed
Additional comments about closing:  1:5.0.r11617.0491831483-1
Comment by Krzysztof Krakowiak (pix3l) - Wednesday, 29 January 2020, 20:03 GMT
  • Field changed: Percent Complete (100% → 0%)
It's a bug, made by incopetence of one of dolphin developers and it's not excuse to package included external headers, which are only needed by dolphin at build time(and dolphin-emu package shouldn't be provider of system-wide rpc-api-header files) (and dolphin-dev stupidity cannot be excuse for making mess with system packages. It's distro-developers jobs to fix upstream mess!)
you can simply add rm -rf "$pkgdir/usr/include/discord*"
Comment by Eli Schwartz (eschwartz) - Wednesday, 29 January 2020, 20:06 GMT
  • Field changed: Summary (community/dolphin-emu 1:5.0.r11530.ea9b96370d-1 conflicts with discord-rpc-api → [dolphin-emu] provides weird files from vendored dependency)
  • Field changed: Status (Unconfirmed → Assigned)
  • Task assigned to Maxime Gauduin (Alucryd)
The bug report is poorly worded and no one cares if something conflicts with something from the AUR.

The ACTUAL issue is that the package has "strange" headers being installed, and also a static library, for utterly no reason.

The problem can and should be solved by properly moving the package's dependencies to the repos, and properly building the package against system copies of the dependency.
Comment by Maxime Gauduin (Alucryd) - Monday, 03 February 2020, 16:44 GMT
This api is deprecated in favor of the discord game sdk and the repository has been archived, I don't think it's wise to package it at this point. I'll just remove the offending files.

Loading...