FS#65259 - [telegram-desktop] contains unneeded Use-system-wide-fonts.patch

Attached to Project: Community Packages
Opened by Ilya Fedin (ilya-fedin) - Friday, 24 January 2020, 20:30 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Wednesday, 18 March 2020, 14:02 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Jiachen Yang (farseerfc)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

A lot of work has been done at tdesktop to support dynamic builds. Currently, tdesktop don't bundle any font if DESKTOP_APP_USE_PACKAGED_FONTS=ON (which is the default if DESKTOP_APP_USE_PACKAGED=ON, which is the default).

Moreover, only these cmake options actually needed:
-DCMAKE_INSTALL_PREFIX=/usr \
-DCMAKE_BUILD_TYPE=Release \
-DTDESKTOP_API_TEST=ON \
-DDESKTOP_APP_USE_PACKAGED_RLOTTIE=OFF \
-DTDESKTOP_USE_PACKAGED_TGVOIP=OFF

+ files installation through make install / ninja install is supported also.
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Wednesday, 18 March 2020, 14:02 GMT
Reason for closing:  Implemented
Comment by Sven-Hendrik Haase (Svenstaro) - Sunday, 26 January 2020, 03:30 GMT
Thanks for the hints. Can you test rel -2?
Comment by Ilya Fedin (ilya-fedin) - Sunday, 26 January 2020, 05:47 GMT
But install() is not changed, as are the cmake flags...
Comment by Jiachen Yang (farseerfc) - Thursday, 30 January 2020, 02:54 GMT
Now 1.9.9-1 is using ninja to install files.

I will need to continue read the cmake rules to see how those cmake options affected the packaging.
Comment by Sven-Hendrik Haase (Svenstaro) - Tuesday, 17 March 2020, 15:52 GMT
I've integrated all changes that seem useful to me. Please have a look. I believe we need what we have in the PKGBUILD right now as a minimal set of commands but I'd like to be proven wrong.
Comment by Ilya Fedin (ilya-fedin) - Tuesday, 17 March 2020, 16:03 GMT
enchant has been replaced by hunspell
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 18 March 2020, 11:01 GMT
Indeed, good catch. rel -3 has the fix.
Comment by Ilya Fedin (ilya-fedin) - Wednesday, 18 March 2020, 12:41 GMT
Thank you, I think the issue can be closed.
Comment by Sven-Hendrik Haase (Svenstaro) - Wednesday, 18 March 2020, 14:02 GMT
Nice, thanks a lot for the input.

Loading...