FS#65189 - alpm-hooks Type=File should be replaced by Type=Path

Attached to Project: Arch Linux
Opened by AMM (amish) - Saturday, 18 January 2020, 02:55 GMT
Last edited by Eli Schwartz (eschwartz) - Sunday, 19 January 2020, 02:19 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Eli Schwartz (eschwartz)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
man alpm-hooks says this:

Type = Path|Package
... File is a deprecated alias for Path and will be removed in a future release.

But when I see /usr/share/libalpm/hooks many hooks under it are still using Type=File.

I think this should be changed before alpm (or pacman) drops support for it.
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Sunday, 19 January 2020, 02:19 GMT
Reason for closing:  Fixed
Additional comments about closing:  I've grepped for all packages that currently use this, and made a TODO list: https://www.archlinux.org/todo/alpm-hook s-should-use-type-path-not-file/
Comment by Allan McRae (Allan) - Sunday, 19 January 2020, 01:57 GMT
Reopening until a TODO list is made an relevant Arch packagers are informed.
Comment by Allan McRae (Allan) - Sunday, 19 January 2020, 01:59 GMT
Eli has said he will make the TODO list!
Comment by Eli Schwartz (eschwartz) - Sunday, 19 January 2020, 02:12 GMT
That is why it is "deprecated", not "removed".

This is a completely non-actionable bug report as-is, since advising the pacman project to avoid being hasty in removing the deprecated alias is useless (why would you think we will be?) and no effort has been made to make this bug report be useful for any other purpose, like providing a todo list of packages which need to be fixed, which you should know since you figured this out somehow...

That being said, wow, I did not realize there wasn't even a single package that switched over yet. It's been months...

FWIW: Our plan has been to raise the visibility of the current debug-level warning in a future release, and then in yet another future release actually remove legacy support.

Loading...