Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#65123 - [fzf] fish function should be installed to /usr/share/fish/vendor_functions.d

Attached to Project: Community Packages
Opened by Johannes Altmanninger (krobelus) - Sunday, 12 January 2020, 16:20 GMT
Last edited by Morten Linderud (Foxboron) - Saturday, 29 February 2020, 13:06 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Morten Linderud (Foxboron)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
fish functions owned by packages other than fish should be installed to /usr/share/fish/vendor_functions.d instead of /usr/share/fish/functions.
This has the advantage that fish can be installed to a prefix and still use the fzf_key_bindings from vendor_functions.d.

Additional info:
fzf 0.20.0-1
Upstream comment on a similar issue: https://github.com/fish-shell/fish-shell/issues/5822#issuecomment-484089720

Suggested fix:

```diff
diff --git a/fzf/trunk/PKGBUILD b/fzf/trunk/PKGBUILD
index 7b831e01d21..a4e442cbe65 100644
--- a/fzf/trunk/PKGBUILD
+++ b/fzf/trunk/PKGBUILD
@@ -54,7 +54,7 @@ package() {
install -m644 shell/*.bash shell/*.zsh "$pkgdir"/usr/share/fzf

## Fish keybindings
- install -Dm644 shell/key-bindings.fish "$pkgdir"/usr/share/fish/functions/fzf_key_bindings.fish
+ install -Dm644 shell/key-bindings.fish "$pkgdir"/usr/share/fish/vendor_functions.d/fzf_key_bindings.fish

## Vim plugin
install -Dm644 plugin/fzf.vim "$pkgdir"/usr/share/vim/vimfiles/plugin/fzf.vim
```
This task depends upon

Closed by  Morten Linderud (Foxboron)
Saturday, 29 February 2020, 13:06 GMT
Reason for closing:  Fixed
Additional comments about closing:  0.20.0-4

Loading...