FS#65075 - [python-tensorflow-opt-cuda] package doesn't mark tensorflow-gpu as installed
Attached to Project:
Community Packages
Opened by RuRo (ruro) - Tuesday, 07 January 2020, 18:40 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Thursday, 16 January 2020, 12:07 GMT
Opened by RuRo (ruro) - Tuesday, 07 January 2020, 18:40 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Thursday, 16 January 2020, 12:07 GMT
|
Details
Description:
The `python-tensorflow-opt-cuda` and `python-tensorflow-cuda` packages install (according to pip) a package named `tensorflow`, however, the other official packages expect the name of the package (with gpu capabilities) to be called `tensorflow-gpu`. For example, after installing `python-tensorflow-opt-cuda` and `python-tensorflow-serving-api`, you will find out that `pip check` complains that "tensorflow-serving-api-gpu 2.0.0 requires tensorflow-gpu, which is not installed". Additionally attempting to `pip install --user` any package, which lists tensorflow-gpu as a requirement will attempt to install `tensorflow-gpu` from PyPI, even though it's already installed system-wide. |
This task depends upon
Closed by Sven-Hendrik Haase (Svenstaro)
Thursday, 16 January 2020, 12:07 GMT
Reason for closing: Fixed
Thursday, 16 January 2020, 12:07 GMT
Reason for closing: Fixed
https://github.com/tensorflow/tensorflow/blob/a396eb4a3a7dc08b859df42919fcc7bdf8236a01/tensorflow/tools/ci_build/builds/pip_new.sh#L631
So I would propose adding "--gpu --project_name tensorflow_gpu" to lines 121 and 136 of the PKGBUILD. (I didn't have time to check, if this works yet, but this seems right given that it's how they build it themselves.)
If I understand correctly, then just adding '--gpu' is not sufficient.
The pip_new.sh script builds the same bazel build_pip_package target as our PKGBUILD, so if they need to set the "--project_name", then we also probably should.
Unless I am missing something, I don't see, how the line you linked to justifies just adding "--gpu".