FS#65066 - [waybar] Build with gtk-layer-shell

Attached to Project: Community Packages
Opened by Simon Doppler (dopsi) - Tuesday, 07 January 2020, 08:54 GMT
Last edited by Brett Cornwall (ainola) - Thursday, 27 February 2020, 00:59 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Brett Cornwall (ainola)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 4
Private No

Details

Description:

When the package is built without gtk-layer-shell[1] installed,
the popup are centered on the screen in sway. Since version 0.9.0[2],
this was fixed by using the layer shell protocol, implemented by
gtk-layer-shell[1].


Additional info:
* package version:
* waybar 0.9.0-1
* sway 1:1.2-5
* gtk-layer-shell 0.1.0-1
* default config for waybar
* link to upstream PR: https://github.com/Alexays/Waybar/pull/441
* link to upstream release notes: https://github.com/Alexays/Waybar/releases/tag/0.9.0
* other info: https://www.reddit.com/r/archlinux/comments/ehu9vk/waybar_v090_correct_positioning_of_tooltips_and/

Steps to reproduce:

Start waybar under sway, put the mouse on a module: the popup is in the center of the screen.

--

[1] https://aur.archlinux.org/packages/gtk-layer-shell/
[2] https://github.com/Alexays/Waybar/releases/tag/0.9.0
   0001-Add-gtk-layer-shell-depe... (0.8 KiB)
This task depends upon

Closed by  Brett Cornwall (ainola)
Thursday, 27 February 2020, 00:59 GMT
Reason for closing:  Implemented
Additional comments about closing:  waybar-0.9.1-1 is now built with gtk-layer-shell support.
Comment by Brett Cornwall (ainola) - Friday, 17 January 2020, 19:51 GMT
I don't think this should be done at the current moment: I had attempted to build it when the feature was first released but it caused all sorts of buggy behavior. As it's disabled by default by upstream, I decided that it was not a good feature to enable at this time.
Comment by Mikhail Khvoinitsky (m_khvoinitsky) - Sunday, 23 February 2020, 19:53 GMT
> it caused all sorts of buggy behavior

It fixes a lot more buggy behaviour (pop-up focus and positioning) than creates — I've noticed only pop-ups hidden under windows if using "layer": "bottom". "layer": "top" fixes the issue.

> As it's disabled by default by upstream

It is only disabled if gtk-layer-shell is not found by meson.
Comment by Simon Wydooghe (HyperBaton) - Monday, 24 February 2020, 12:43 GMT
I just compiled Waybar with gtk-layer-support and it works nicely for me. It's definitely a major improvement over the windows floating in the middle of the screen :) Would be nice if this could be enabled in the Arch package.
Comment by Brett Cornwall (ainola) - Monday, 24 February 2020, 15:35 GMT
It'll be available in the next update. Some other things need to be sorted out first.
Comment by Simon Wydooghe (HyperBaton) - Monday, 24 February 2020, 20:01 GMT
Awesome!
Comment by Brett Cornwall (ainola) - Wednesday, 26 February 2020, 04:12 GMT
Hi all,

waybar-0.9.1-1 is now in [community-testing]. Please test and report back if something is not right.

Thanks!
Comment by Simon Wydooghe (HyperBaton) - Wednesday, 26 February 2020, 08:13 GMT
Works!

Loading...