FS#65034 - Separate Text from Footer in Comment notification E-Mail
Attached to Project:
AUR web interface
Opened by Stephan S (buzo) - Friday, 03 January 2020, 20:43 GMT
Last edited by Lukas Fleischer (lfleischer) - Tuesday, 21 April 2020, 16:01 GMT
Opened by Stephan S (buzo) - Friday, 03 January 2020, 20:43 GMT
Last edited by Lukas Fleischer (lfleischer) - Tuesday, 21 April 2020, 16:01 GMT
|
Details
It would be nice if the footer in the comment notification
e-mails would somehow be separated from the comment text.
This confuses me on every e-mail.
My suggestion is to add the standard signature delimiter (dash dash space, RFC 3676), but any other delimiter would work, too. Thus my suggested patch is: diff --git a/aurweb/scripts/notify.py b/aurweb/scripts/notify.py index 591b5ca..c5e203f 100755 --- a/aurweb/scripts/notify.py +++ b/aurweb/scripts/notify.py @@ -151,7 +151,7 @@ class CommentNotification(Notification): body = self._l10n.translate( '{user} [1] added the following comment to {pkgbase} [2]:', lang).format(user=self._user, pkgbase=self._pkgbase) - body += '\n\n' + self._text + '\n\n' + body += '\n\n' + self._text + '\n\n-- \n' dnlabel = self._l10n.translate('Disable notifications', lang) body += self._l10n.translate( 'If you no longer wish to receive notifications about this ' |
This task depends upon
Closed by Lukas Fleischer (lfleischer)
Tuesday, 21 April 2020, 16:01 GMT
Reason for closing: Implemented
Additional comments about closing: Implemented in 5.0.0.
Tuesday, 21 April 2020, 16:01 GMT
Reason for closing: Implemented
Additional comments about closing: Implemented in 5.0.0.
Comment by
Lukas Fleischer (lfleischer) -
Saturday, 04 January 2020, 11:36 GMT
Comment by Stephan S (buzo) -
Saturday, 04 January 2020, 13:02 GMT
Comment by
Lukas Fleischer (lfleischer) -
Monday, 06 January 2020, 15:38 GMT
Great idea! Could you please create a proper Git-formatted patch
with git-format-patch(1) and attach it as a file here?
done
Merged into pu, thanks!