AUR web interface

**This is the bug tracker for the AUR web interface.**

Use this tracker to report bugs or make feature requests regarding the behaviour or implementation of the AUR software.
Please read the Reporting Bug Guidelines before filing a new task.
http://wiki.archlinux.org/index.php/Reporting_Bug_Guidelines

- Please report bugs related to Arch Linux official packages here: http://bugs.archlinux.org/index.php?project=1
- Please report bugs for [community] packages here: http://bugs.archlinux.org/index.php?project=5
- For any packages in the AUR contact the maintainer or leave a comment on the package's detail page.

Source Code:
https://projects.archlinux.org/aurweb.git/
Tasklist

FS#65034 - Separate Text from Footer in Comment notification E-Mail

Attached to Project: AUR web interface
Opened by Stephan S (buzo) - Friday, 03 January 2020, 20:43 GMT
Last edited by Lukas Fleischer (lfleischer) - Tuesday, 21 April 2020, 16:01 GMT
Task Type Feature Request
Category Backend
Status Closed
Assigned To No-one
Architecture All
Severity Medium
Priority Normal
Reported Version 4.7.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

It would be nice if the footer in the comment notification e-mails would somehow be separated from the comment text. This confuses me on every e-mail.

My suggestion is to add the standard signature delimiter (dash dash space, RFC 3676), but any other delimiter would work, too.

Thus my suggested patch is:

diff --git a/aurweb/scripts/notify.py b/aurweb/scripts/notify.py
index 591b5ca..c5e203f 100755
--- a/aurweb/scripts/notify.py
+++ b/aurweb/scripts/notify.py
@@ -151,7 +151,7 @@ class CommentNotification(Notification):
body = self._l10n.translate(
'{user} [1] added the following comment to {pkgbase} [2]:',
lang).format(user=self._user, pkgbase=self._pkgbase)
- body += '\n\n' + self._text + '\n\n'
+ body += '\n\n' + self._text + '\n\n-- \n'
dnlabel = self._l10n.translate('Disable notifications', lang)
body += self._l10n.translate(
'If you no longer wish to receive notifications about this '
This task depends upon

Closed by  Lukas Fleischer (lfleischer)
Tuesday, 21 April 2020, 16:01 GMT
Reason for closing:  Implemented
Additional comments about closing:  Implemented in 5.0.0.
Comment by Lukas Fleischer (lfleischer) - Saturday, 04 January 2020, 11:36 GMT
Great idea! Could you please create a proper Git-formatted patch with git-format-patch(1) and attach it as a file here?
Comment by Stephan S (buzo) - Saturday, 04 January 2020, 13:02 GMT
done
Comment by Lukas Fleischer (lfleischer) - Monday, 06 January 2020, 15:38 GMT
Merged into pu, thanks!

Loading...