FS#65012 - [python-clikit] ValueError with python-pastel-0.2.0 when running poetry

Attached to Project: Community Packages
Opened by Dror Levin (spatz) - Thursday, 02 January 2020, 08:36 GMT
Last edited by Eli Schwartz (eschwartz) - Thursday, 02 January 2020, 15:29 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Eli Schwartz (eschwartz)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
Since upgrading to python-pastel-0.2.0 I'm getting the following error with poetry:
Traceback (most recent call last):
File "/usr/bin/poetry", line 11, in <module>
load_entry_point('poetry==1.0.0', 'console_scripts', 'poetry')()
File "/usr/lib/python3.8/site-packages/poetry/console/__init__.py", line 5, in main
return Application().run()
File "/usr/lib/python3.8/site-packages/poetry/console/application.py", line 32, in __init__
super(Application, self).__init__(
File "/usr/lib/python3.8/site-packages/cleo/application.py", line 29, in __init__
super(Application, self).__init__(config)
File "/usr/lib/python3.8/site-packages/clikit/console_application.py", line 32, in __init__
self._preliminary_io = ConsoleIO()
File "/usr/lib/python3.8/site-packages/clikit/io/console_io.py", line 31, in __init__
formatter = AnsiFormatter()
File "/usr/lib/python3.8/site-packages/clikit/formatter/ansi_formatter.py", line 26, in __init__
pastel_style = StyleConverter.convert(style)
File "/usr/lib/python3.8/site-packages/clikit/adapter/style_converter.py", line 30, in convert
return PastelStyle(style.foreground_color, style.background_color, options)
File "/usr/lib/python3.8/site-packages/pastel/style.py", line 74, in __init__
self.set_options(options)
File "/usr/lib/python3.8/site-packages/pastel/style.py", line 133, in set_options
self.set_option(option)
File "/usr/lib/python3.8/site-packages/pastel/style.py", line 110, in set_option
raise ValueError(
ValueError: Invalid option specified: "underscore". Expected one of (bold, dark, italic, underline, blink, reverse, conceal)

This is caused by an incorrect dependency in python-clikit - the python package requires pastel in version ^0.1.0 meaning >=0.1.0,<0.2.0 but since in Arch it was bumped this is now broken.

Additional info:
* package version(s)
python-clikit 0.4.1-1
python-pastel 0.2.0-1
python-poetry 1.0.0-2

Steps to reproduce:
1. pacman -S python-poetry
2. poetry --help
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Thursday, 02 January 2020, 15:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  python-clikit 0.4.1-2
Comment by Eli Schwartz (eschwartz) - Thursday, 02 January 2020, 15:12 GMT
Ugh. A 400-line diff between the old and new pastel versions was more or less entirely changing single quotes to double quotes "because python-black", or changing how many lines a function call used to specify parameters.

Then there was, apparently, this: https://github.com/sdispater/pastel/commit/af19b70eba6cc46bb94b31b91f5d5f5f81aa25ad

Which "added" stuff, right, except it also renamed something for no good reason. Nice.

My inclination is to patch clikit to use "underline" instead of "underscore".
Comment by Eli Schwartz (eschwartz) - Thursday, 02 January 2020, 15:27 GMT

Loading...