FS#64923 - [php] breaking change due to changed maintainers config

Attached to Project: Arch Linux
Opened by Thomas Flori (iras) - Saturday, 21 December 2019, 10:47 GMT
Last edited by Pierre Schmitz (Pierre) - Wednesday, 25 December 2019, 13:05 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
A new configuration value got changed in the repo. This fails my unit tests and as such is a breaking change.

```
; Allows to include or exclude arguments from stack traces generated for exceptions
; Default: Off
; In production, it is recommended to turn this setting on to prohibit the output
; of sensitive information in stack traces
zend.exception_ignore_args = On
```

By default this is Off but in the repo it is On. The default is Off for a reason: no breaking changes. I was very shocked today especially because you don't find it everywhere that there is a new ini configuration that does not change anything except if you enable it.

Additional info:
php 7.4.0-2

Steps to reproduce:
As I was very wondered I thought it is only for closures and so I created a test script. I almost opened a bug report for php with this paste:
https://pastebin.com/k7AhkKgZ
This task depends upon

Closed by  Pierre Schmitz (Pierre)
Wednesday, 25 December 2019, 13:05 GMT
Reason for closing:  Not a bug
Comment by Thomas Flori (iras) - Saturday, 21 December 2019, 10:52 GMT
sorry can't edit anymore.. I missed to change the summary. I would summarize: breaking change due to changed maintainers config
Comment by Doug Newgard (Scimmia) - Saturday, 21 December 2019, 15:49 GMT
php.ini-production has been installed as php.ini for a very long time.
Comment by Eli Schwartz (eschwartz) - Sunday, 22 December 2019, 20:42 GMT
  • Field changed: Summary ([php] PLEASE ENTER SUMMARY → [php] breaking change due to changed maintainers config)
Fixed summary per request.
Comment by Eli Schwartz (eschwartz) - Sunday, 22 December 2019, 20:45 GMT
https://github.com/php/php-src/commit/0819e6dc9b4788e5d44b64f8e606a56c969a1588

The initial implementation of this made sure it was enabled for "production environments" by default, which seems like a reasonable decision to make... and archlinux ships a production config by default. Is there anything broken other than unittests?
Comment by Pierre Schmitz (Pierre) - Wednesday, 25 December 2019, 13:05 GMT
We just ship the upstream production config as a reasonable default config. If your application needs a different config its meant to be adjusted. I do not see a packaging bug here.

Loading...