FS#64746 - [ell] add --enable-maintainer-mode to configure flags

Attached to Project: Arch Linux
Opened by Christian Rebischke (Shibumi) - Thursday, 05 December 2019, 17:27 GMT
Last edited by Andreas Radke (AndyRTR) - Tuesday, 17 December 2019, 08:10 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Andreas Radke (AndyRTR)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Hi Andreas,

We need to add the --enable-maintainer-mode flag to the configure in the build section for compiling all unit tests. (looks like 3 tests are missing with our current PKGBUILD).

Best regards,

chris
This task depends upon

Closed by  Andreas Radke (AndyRTR)
Tuesday, 17 December 2019, 08:10 GMT
Reason for closing:  Won't implement
Comment by Eli Schwartz (eschwartz) - Thursday, 05 December 2019, 18:06 GMT
  • Field changed: Attached to Project (Community Packages → Arch Linux)
  • Field changed: Summary ([ell] add --maintainer-mode to configure flags → [ell] Add openssl as make dependency)
  • Field changed: Details
Wrong project.
Comment by Andreas Radke (AndyRTR) - Wednesday, 11 December 2019, 14:46 GMT
As already told in IRC --enable-maintainer-mode requires additional "vim" makedependency(xxd required). All 3 additional tests fail here with gcc:

================================
ell 0.26: ./test-suite.log
================================

# TOTAL: 41
# PASS: 38
# SKIP: 0
# XFAIL: 0
# FAIL: 3
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: unit/test-pem
===================

test-pem: unit/test-pem.c:173: test_chain_from_data: Assertion `l_certchain_verify(chain, twocas, NULL)' failed.
FAIL unit/test-pem (exit status: 134)

FAIL: unit/test-tls
===================

test-tls: unit/test-tls.c:250: test_certificates: Assertion `l_certchain_verify(chain, cacert, NULL)' failed.
FAIL unit/test-tls (exit status: 134)

FAIL: unit/test-key
===================

test-key: unit/test-key.c:71: test_user: Assertion `key' failed.
FAIL unit/test-key (exit status: 134)

check https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/README - we have several kernel modules not compiled into the kernel but as modules.
We have CONFIG_CRYPTO_USER_API=m + CONFIG_CRYPTO_USER_API_HASH=m built as modules and you never know on what cpu type you're running the build so no clue that module to preload.

Denis Kenzior told me in IRC #ell that all kernel modules need to be loaded to run the tests. Module loading isn't supported when building packages inside chroots.
There's nothing we can do to pass these additional test. You would have to build and run the tests outside a chroot or we would need to build the modules into the kernel itself. That's not worth here.

So I'm going to close this one as "won't implement" as the maintainer-mode improves nothing here.

Loading...