Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#64622 - [file] breaks makepkg detection of gzipped patches

Attached to Project: Arch Linux
Opened by Andreas Baumann (andreas_baumann) - Saturday, 23 November 2019, 16:26 GMT
Last edited by Eli Schwartz (eschwartz) - Monday, 02 December 2019, 07:30 GMT
Task Type Bug Report
Category Packages: Core
Status Closed
Assigned To Sébastien Luttringer (seblu)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

==> Retrieving sources...
-> Found gwaterfall_0.1.orig.tar.gz
-> Found gwaterfall_0.1-5.1.diff.gz
==> WARNING: Skipping all source file integrity checks.
==> Extracting sources...
-> Extracting gwaterfall_0.1.orig.tar.gz with bsdtar
==> Starting prepare()...
patch: **** Can't open patch file /build/gwaterfall/src/gwaterfall_0.1-5.1.diff : No such file or directory
==> ERROR: A failure occurred in prepare().
Aborting...
==> ERROR: Build failed, check /var/lib/archbuild/staging-x86_64

Additional info:
* package version(s): 0.1-2

Steps to reproduce:
asp update
asp export extra/gwaterfall (same for asp export gwaterfall)
staging-x86_64-build
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Monday, 02 December 2019, 07:30 GMT
Reason for closing:  Fixed
Additional comments about closing:  file 5.37-5
Comment by Eli Schwartz (eschwartz) - Sunday, 24 November 2019, 00:51 GMT
  • Field changed: Summary ([gwaterfall] patch file is in gzip format, build fails → [file] breaks makepkg detection of gzipped patches)
  • Field changed: Status (Unconfirmed → Assigned)
  • Field changed: Category (Packages: Extra → Packages: Core)
  • Field changed: Severity (Low → Medium)
  • Task assigned to Sébastien Luttringer (seblu)
https://bugs.astron.com/view.php?id=112 detection of gzipped files is badly broken.

Old/git-master:

$ ./tempinstall/bin/file -bizL ../gwaterfall_0.1-5.1.diff.gz
text/x-diff; charset=utf-8 compressed-encoding=application/gzip; charset=binary

Current:

$ file -bizL ../gwaterfall_0.1-5.1.diff.gz
text/x-diff; charset=utf-8 compressed-encoding=application/octet-stream; charset=binary

application/octet-stream is completely incorrect here!

Broken in https://github.com/file/file/commit/3c12eb8d1418181af93abdd466c64dcddf68ce16

Fixed with https://github.com/file/file/commit/d3132f65594e8ad27b74643786a786cd3e60c715

Please backport this regression fix.
Comment by Sébastien Luttringer (seblu) - Thursday, 28 November 2019, 01:29 GMT
Fix in file-5.37-5, let me know if it's ok.
Comment by Eli Schwartz (eschwartz) - Monday, 02 December 2019, 07:30 GMT
The test case of the gwaterfall package now builds successfully.

Loading...