FS#64543 - [cinnamon] applets fail

Attached to Project: Community Packages
Opened by Gérald Rochat (grochat) - Sunday, 17 November 2019, 09:50 GMT
Last edited by Eli Schwartz (eschwartz) - Friday, 22 November 2019, 19:45 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Eli Schwartz (eschwartz)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

cinnamon-settings a

Additional info:
* package version(s) 4.2.4-2

Steps to reproduce:

Simply launch applets settings in control panel or cinnamon-settings applets in terminal.
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Friday, 22 November 2019, 19:45 GMT
Reason for closing:  Fixed
Additional comments about closing:  cinnamon 4.2.4-3
Comment by morganamilo (morganamilo) - Sunday, 17 November 2019, 11:29 GMT
You should give more information. How does it fail? Does it not work at all? Is there any error message?
Comment by Gérald Rochat (grochat) - Sunday, 17 November 2019, 12:47 GMT
When i click on applet in control panel nothing is happening.
When i type "cinnamon-settings applets" in a terminal there are several python errors.
like this:

╭─gerald@i5 ~
╰─➤ cinnamon-settings applets
True
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:421: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if category.int_name is not "custom":
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:430: SyntaxWarning: "is" with a literal. Did you mean "=="?
if category.int_name is "custom":
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:445: SyntaxWarning: "is" with a literal. Did you mean "=="?
if category.int_name is "custom":
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:455: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if entry is not "_invalid_":
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:538: SyntaxWarning: "is" with a literal. Did you mean "=="?
if cat[2].int_name is "custom":
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:576: SyntaxWarning: "is" with a literal. Did you mean "=="?
if cat[2].int_name is "custom":
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:602: SyntaxWarning: "is" with a literal. Did you mean "=="?
if cat[2].int_name is "custom":
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:693: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if entry is not "":
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:733: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if entry is not "":
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:779: SyntaxWarning: "is not" with a literal. Did you mean "!="?
ok_enabled = self.name_entry.get_text().strip() is not "" and self.command_entry.get_text().strip() is not ""
/usr/share/cinnamon/cinnamon-settings/modules/cs_keyboard.py:779: SyntaxWarning: "is not" with a literal. Did you mean "!="?
ok_enabled = self.name_entry.get_text().strip() is not "" and self.command_entry.get_text().strip() is not ""
Using pam module (python3-pampy)
/usr/share/cinnamon/cinnamon-settings/cinnamon-settings.py:423: DeprecationWarning: Gtk.Window.set_wmclass is deprecated
self.window.set_wmclass(wm_class, wm_class)
Loading Applets module
Traceback (most recent call last):
File "/usr/share/cinnamon/cinnamon-settings/cinnamon-settings.py", line 724, in <module>
window = MainWindow()
File "/usr/share/cinnamon/cinnamon-settings/cinnamon-settings.py", line 428, in __init__
self.go_to_sidepage(cat, path, user_action=False)
File "/usr/share/cinnamon/cinnamon-settings/cinnamon-settings.py", line 185, in go_to_sidepage
sidePage.build()
File "/usr/share/cinnamon/cinnamon-settings/bin/SettingsWidgets.py", line 123, in build
self.module.on_module_selected()
File "/usr/share/cinnamon/cinnamon-settings/modules/cs_applets.py", line 21, in on_module_selected
self.sidePage.load(self.window)
File "/usr/share/cinnamon/cinnamon-settings/modules/cs_applets.py", line 46, in load
download_applets_page = DownloadSpicesPage(self, self.collection_type, self.spices, window)
File "/usr/share/cinnamon/cinnamon-settings/bin/ExtensionCore.py", line 810, in __init__
self.build_list()
File "/usr/share/cinnamon/cinnamon-settings/bin/ExtensionCore.py", line 897, in build_list
msg_text = _("Update all") + ' (' + ngettext("%d update available", "%d updates available", updates_available) % updates_available + ')'
NameError: name 'ngettext' is not defined
Comment by Eli Schwartz (eschwartz) - Sunday, 17 November 2019, 14:28 GMT
That seems pretty broken, so I submitted an upstream PR here: https://github.com/linuxmint/cinnamon/pull/8964

Given that the cinnamon 4.4 ecosystem is in the process of being tagged with lots of interesting changes, I may end up simply waiting until then to apply the fix to our package.
Comment by Gérald Rochat (grochat) - Sunday, 17 November 2019, 14:57 GMT
It seems that the problem does not come from cinnamon but from the SpiceUpdate applet.
https://github.com/linuxmint/cinnamon/issues/8956

It's the same problem.
Remove SpiceUpdate by right click on the applet in panel then remove /home/$USER/.local/share/cinnamon/applets/SpicesUpdate@claudiux and it works again.

Loading...