FS#64503 - [lutris] HTTP client broken by Python 3.8

Attached to Project: Community Packages
Opened by Sebastian Schwarz (seschwar) - Friday, 15 November 2019, 00:52 GMT
Last edited by Filipe Laíns (FFY00) - Sunday, 17 November 2019, 16:25 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Filipe Laíns (FFY00)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 6
Private No

Details

Description:

Lutris 0.5.3 uses Python's platform.dist() function, which was deprecated in Python 3.5 and completely removed in Python 3.8. With Python 3.8 now being the default Python version Lutris is no longer able to interact with online services over HTTP, since it puts platform.dist() in the User-Agent HTTP header. This means one can no longer search lutris.net from the GUI, install runners or manage Wine versions.

Lutris' master already has a patch which fixes this issue and restores full functionality with Python 3.8: https://github.com/lutris/lutris/commit/2f7c3b1aefc96608d814e2ad37b6c49c687fae1b

Please backport this patch to restore the packages full functionality with Python 3.8.

Additional info:
* package version(s)
lutris 0.5.3-2
python 3.8.0-1

Steps to reproduce:

# pacman -S lutris
(...)
$ lutris
(...)
<class 'AttributeError'> module 'platform' has no attribute 'dist'
File "/usr/lib/python3.8/site-packages/lutris/util/jobs.py", line 30, in target
result = self.function(*args, **kwargs)
File "/usr/lib/python3.8/site-packages/lutris/runtime.py", line 143, in update
for remote_runtime in self._iter_remote_runtimes():
File "/usr/lib/python3.8/site-packages/lutris/runtime.py", line 152, in _iter_remote_runtimes
request = http.Request(RUNTIME_URL)
File "/usr/lib/python3.8/site-packages/lutris/util/http.py", line 48, in __init__
self.headers = {"User-Agent": self.user_agent}
File "/usr/lib/python3.8/site-packages/lutris/util/http.py", line 64, in user_agent
PROJECT, VERSION, " ".join(platform.dist()), platform.machine()

This task depends upon

Closed by  Filipe Laíns (FFY00)
Sunday, 17 November 2019, 16:25 GMT
Reason for closing:  Fixed
Additional comments about closing:  lutris 0.5.3-3
Comment by Observer of Time (chronobserver) - Saturday, 16 November 2019, 18:19 GMT
Here's a patched PKGBUILD.
   PKGBUILD (1.3 KiB)

Loading...