FS#64297 - [qpdfview] add static_resources build option for translation support

Attached to Project: Community Packages
Opened by Yoann P (Y0) - Monday, 28 October 2019, 17:58 GMT
Last edited by freswa (frederik) - Monday, 14 September 2020, 15:03 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Alad Wenter (Alad)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
Qpdfview is always in english.
qpdfview readme state:
The following build-time options are available:
[...]
'static_resources' to statically embed resources like translations and online help into the application binary.

PKGBUILD change:
from (line 30):
qmake-qt5 qpdfview.pro
to (line 30):
qmake-qt5 CONFIG+="static_resources" qpdfview.pro

Additionnal info:
pkgver=0.4.18
This task depends upon

Closed by  freswa (frederik)
Monday, 14 September 2020, 15:03 GMT
Reason for closing:  Fixed
Additional comments about closing:  0.4.18-2
Comment by Alad Wenter (Alad) - Tuesday, 19 November 2019, 20:39 GMT
Why? They can just be part of the package, no need to embed them in the binary.
Comment by Yoann P (Y0) - Sunday, 01 December 2019, 18:44 GMT
Not sure to understand the diff. between pkg. and binary :/.
But currently those file are missing from package:
[...]
/usr/share/qpdfview/qpdfview_es.qm
/usr/share/qpdfview/qpdfview_eu.qm
/usr/share/qpdfview/qpdfview_fi.qm
/usr/share/qpdfview/qpdfview_fr.qm
[...]
So no translation, it's english or english.
Comment by nikatar (nikatar) - Friday, 17 April 2020, 19:36 GMT
I build the package as Yoann P wrote. Now translations appeared.
Thank you!
Fix this bug please
Comment by freswa (frederik) - Monday, 14 September 2020, 14:11 GMT
I had a look at this. At the moment this doesn't even build with several g++ errors..
Comment by loqs (loqs) - Monday, 14 September 2020, 14:56 GMT
This patch should allow the package to build.
   test.patch (0.3 KiB)

Loading...