FS#64283 - Change dependencies on gnome-keyring

Attached to Project: Community Packages
Opened by Bruno Pagani (ArchangeGabriel) - Sunday, 27 October 2019, 10:32 GMT
Last edited by Jan de Groot (JGC) - Monday, 10 May 2021, 11:44 GMT
Task Type General Gripe
Category Packages
Status Closed
Assigned To Jan de Groot (JGC)
Jan Alexander Steffens (heftig)
Maxime Gauduin (Alucryd)
Bruno Pagani (ArchangeGabriel)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

We have some packages with dependency on gnome-keyring, like Geary, that actually do not require strictly gnome-keyring but a service implementing org.freedesktop.secrets, which we now have at least two of them (gnome-keyring and keepassxc).

Maybe we should create a virtual provides `org.freedesktop.secrets` and add it to both keepassxc and gnome-keyring, and then switch all dependencies on gnome-keyring to this virtual package. Any opinion? Should I start a TODO for this?
This task depends upon

Closed by  Jan de Groot (JGC)
Monday, 10 May 2021, 11:44 GMT
Reason for closing:  Implemented
Additional comments about closing:  Todo list is done, so close this.
Comment by Jan Alexander Steffens (heftig) - Sunday, 27 October 2019, 14:20 GMT
Sure, sounds good.
Comment by Maxime Gauduin (Alucryd) - Sunday, 27 October 2019, 21:02 GMT
Agreed, please do.
Comment by Bruno Pagani (ArchangeGabriel) - Monday, 28 October 2019, 10:55 GMT
OK, I just need a dev to add provides=('org.freedesktop.secrets') to gnome-keyring (push directly to [extra], this is no breaking change). I’m doing so for keepassxc myself.
Comment by Jan Alexander Steffens (heftig) - Monday, 28 October 2019, 11:08 GMT
Can we call it 'secrets-service' instead? Dots in the package name look weird and I don't think there's precedence.
Comment by Bruno Pagani (ArchangeGabriel) - Monday, 28 October 2019, 11:18 GMT
I’ve found at least two examples: https://www.archlinux.org/packages/community/any/acme.sh/ and https://www.archlinux.org/packages/community/x86_64/eteroj.lv2/.

But if you prefer 'secrets-service', fine. I’ll push keepassxc again.
Comment by Bruno Pagani (ArchangeGabriel) - Monday, 28 October 2019, 11:22 GMT
Also, it seems kwallet might also provide org.freedesktop.secrets, added arojas in assign to get information on that.
Comment by Antonio Rojas (arojas) - Monday, 28 October 2019, 11:24 GMT
No, it doesn't. It's been long planned but not implemented yet.
Comment by Bruno Pagani (ArchangeGabriel) - Monday, 28 October 2019, 11:24 GMT
@heftig And in that case, it should rather be 'secret-service' I guess (https://specifications.freedesktop.org/secret-service/).
Comment by Bruno Pagani (ArchangeGabriel) - Monday, 28 October 2019, 11:25 GMT
@arojas: OK, thanks for the input.

@heftig: The advantage of the dot name is to avoid any potential naming conflict for the foreseeable future.
Comment by Jan Alexander Steffens (heftig) - Tuesday, 29 October 2019, 09:32 GMT
It's fine; let's use the bus name.

Note that xdg-desktop-portal-gtk will gain a hard dependency on gnome-keyring in the future, as it will be the only implementor of org.freedesktop.portal.Secret.
Comment by Bruno Pagani (ArchangeGabriel) - Sunday, 01 December 2019, 22:40 GMT
Finally added the todo: https://www.archlinux.org/todo/gnome-keyring-dependency-replacement-with-orgfreedesktopsecrets/

Loading...