FS#64213 - [repo-add] Failing to compress the repo database when using .db.tar.zst file extension
Attached to Project:
Pacman
Opened by Nick Cao (NickCao) - Tuesday, 22 October 2019, 06:36 GMT
Last edited by Allan McRae (Allan) - Tuesday, 05 November 2019, 04:59 GMT
Opened by Nick Cao (NickCao) - Tuesday, 22 October 2019, 06:36 GMT
Last edited by Allan McRae (Allan) - Tuesday, 05 November 2019, 04:59 GMT
|
Details
Summary and Info:
Due to errors in handling the TAR_OPT variable (line 537, 541 in repo-add script). tar will be unable to correctly parse the command line flags and thus failing to compress the repo database. Steps to Reproduce: repo-add /tmp/test.db.tar.zst ./test.pkg.tar.xz Output: --Omitted-- ==> Creating updated database file '/tmp/test.db.tar.zst' Usage: List: bsdtar -tf <archive-filename> Extract: bsdtar -xf <archive-filename> Create: bsdtar -cf <archive-filename> [filenames...] Help: bsdtar --help Usage: List: bsdtar -tf <archive-filename> Extract: bsdtar -xf <archive-filename> Create: bsdtar -cf <archive-filename> [filenames...] Help: bsdtar --help mv: cannot stat '/tmp/.tmp.test.db.tar.zst': No such file or directory mv: cannot stat '/tmp/.tmp.test.files.tar.zst': No such file or directory |
This task depends upon
Closed by Allan McRae (Allan)
Tuesday, 05 November 2019, 04:59 GMT
Reason for closing: Fixed
Additional comments about closing: git commit 7df70e7f
Tuesday, 05 November 2019, 04:59 GMT
Reason for closing: Fixed
Additional comments about closing: git commit 7df70e7f
Comment by Nick Cao (NickCao) -
Tuesday, 22 October 2019, 06:41 GMT
A possible fix (The first file is wrong too....)
Comment by
Morten Linderud (Foxboron) -
Tuesday, 22 October 2019, 06:43 GMT
Please post patches. It's impossible to get an overview of what
the fix entails.
Comment by Nick Cao (NickCao) -
Tuesday, 22 October 2019, 06:44 GMT
diff file (silly me
Comment by Nick Cao (NickCao) -
Tuesday, 22 October 2019, 07:02 GMT
The same bug should also affect repo-remove,
Comment by Allan McRae (Allan) -
Tuesday, 22 October 2019, 07:16 GMT
All these patches do is remove the leading "-" in the option and
then compress the options together. Not sure how that actually
fixes the issue.
Comment by Allan McRae (Allan) -
Tuesday, 22 October 2019, 07:18 GMT
Ah - looked at the source... A unified diff would give context
needed to understand the patch.
Comment by Nick Cao (NickCao) -
Tuesday, 22 October 2019, 07:20 GMT
Ah, I misused diff.... Actually the fix is in the reverse way,
adding the leading '-' and splitting the options.
Comment by Allan McRae (Allan) -
Tuesday, 22 October 2019, 07:24 GMT
Sending the fix to the mailing list. Do you mind if I use your
email address from the bug tracker in the author section?
Comment by Nick Cao (NickCao) -
Tuesday, 22 October 2019, 07:24 GMT
That's ok.
Comment by Nick Cao (NickCao) -
Tuesday, 22 October 2019, 07:32 GMT
The same fix is needed for repo-remove, I think....
Comment by Allan McRae (Allan) -
Tuesday, 22 October 2019, 08:03 GMT
No - they are the same script... symlinked to each other.
repo-add
(18.5 KiB)