FS#63973 - [arch-signoff] 0.2.2-1 errors out when attempting to signoff package flagged as 'bad'

Attached to Project: Arch Linux
Opened by jason ryan (jasonwryan) - Tuesday, 01 October 2019, 06:26 GMT
Last edited by Buggy McBugFace (bugbot) - Saturday, 25 November 2023, 20:26 GMT
Task Type General Gripe
Category Packages: Extra
Status Closed
Assigned To Jelle van der Waa (jelly)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Description: Attempting to sign off a package marked as "bad" in the web interface creates the following, unhelpful, error:

:: Sign off mesa? [y/N]: y
Traceback (most recent call last):
File "/usr/bin/signoff", line 11, in <module>
load_entry_point('arch-signoff==0.2.1', 'console_scripts', 'signoff')()
File "/usr/lib/python3.7/site-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "/usr/lib/python3.7/site-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/usr/lib/python3.7/site-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/lib/python3.7/site-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/lib/python3.7/site-packages/signoff/__init__.py", line 401, in main
File "/usr/lib/python3.7/site-packages/signoff/__init__.py", line 72, in signoff_package
File "/usr/lib/python3.7/site-packages/requests/models.py", line 940, in raise_for_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://www.archlinux.org/packages/Testing/x86_64/mesa/signoff/

Steps to reproduce: signoff 'Y' a package marked as "bad"

A more helpful error message would be grand.
This task depends upon

Closed by  Buggy McBugFace (bugbot)
Saturday, 25 November 2023, 20:26 GMT
Reason for closing:  Moved
Additional comments about closing:  https://gitlab.archlinux.org/archlinux/p ackaging/packages/arch-signoff/issues/2
Comment by Matthew Sexton (wsdmatty) - Tuesday, 01 October 2019, 07:10 GMT
I looked at the code...

Lines 72 and ... 84? could be replaced. Instead of "raise_for_status", response could be checked and if it's an error response, raise an exception. If it's error 403, note that this probably means the package is flagged as "bad" and unable to be signed-off on.

I'd do it myself.. but it's 3am and I don't feel like it right now.
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.