FS#63935 - [gitlab] authorized_keys_file on wrong path for gitlab_shell/gitaly

Attached to Project: Community Packages
Opened by Geno (genofire) - Saturday, 28 September 2019, 00:06 GMT
Last edited by Anatol Pomozov (anatolik) - Wednesday, 27 May 2020, 22:41 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No



Additional info:
* gitlab 12.3.1-1

Steps to reproduce:
* new install
* run: rake gitlab:check


--- a/webapps/gitlab/gitlab.yml
+++ b/webapps/gitlab/gitlab.yml
@@ -962,7 +962,7 @@ production: &base
## GitLab Shell settings
path: /usr/share/webapps/gitlab-shell/
- authorized_keys_file: /home/git/.ssh/authorized_keys
+ authorized_keys_file: /var/lib/gitlab/.ssh/authorized_keys
This task depends upon

Closed by  Anatol Pomozov (anatolik)
Wednesday, 27 May 2020, 22:41 GMT
Reason for closing:  Fixed
Additional comments about closing:  13.0.1
Comment by Anatol Pomozov (anatolik) - Wednesday, 27 May 2020, 22:41 GMT
It actually a default config and it is expected that a server owner inspects the files and makes corresponding changes.

Nevertheless it is a good idea to have reasonable default config settings. This is fixed in 13.0.1

$ grep authorized_keys /etc/webapps/gitlab/gitlab.yml
authorized_keys_file: /var/lib/gitlab/.ssh/authorized_keys