FS#63605 - [seamonkey] doesn't build with gcc 9
Attached to Project:
Community Packages
Opened by Andreas Baumann (andreas_baumann) - Friday, 30 August 2019, 12:08 GMT
Last edited by Kyle Keen (keenerd) - Thursday, 12 September 2019, 01:04 GMT
Opened by Andreas Baumann (andreas_baumann) - Friday, 30 August 2019, 12:08 GMT
Last edited by Kyle Keen (keenerd) - Thursday, 12 September 2019, 01:04 GMT
|
Details
Description:
Warnings/errors like: /build/seamonkey/src/seamonkey-2.49.4/mozilla/js/xpconnect/src/XPCWrappedNative.cpp: 2221:41: error: directive argument is null [-Werror=format-overflow=] 2221 | name = JS_sprintf_append(name, fmt, | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~ 2222 | array[i]->GetNameString()); | ~~~~~~~~~~~~~~~~~~~~~~~~~~ Following the advice in: https://bugzilla.mozilla.org/show_bug.cgi?id=1514781 and added a section of flags after the GCC 6 flags: # GCC 9 CFLAGS+=" -Wno-error=class-memaccess -Wno-error=format-overflow -Wno-error=stringo p-truncation -Wno-stringop-overflow -Wno-error=type-limits -Wno-error=deprecated" CXXFLAGS+=" -Wno-error=class-memaccess -Wno-error=format-overflow -Wno-error=strin gop-truncation -Wno-stringop-overflow -Wno-error=attributes -Wno-error=deprecated-co py -Wno-error=pessimizing-move -Wno-error=type-limits -Wno-error=deprecated" makes it compile. I keep you posted whether it also runs.. :-) Additional info: * package version(s): 2.49.4-4 Steps to reproduce: asp export seamonkey cd seamonkey staging-i686-build |
This task depends upon
2221:41: error: â directive argument is null [-Werror=format-overflow=]
2221 | name = JS_sprintf_append(name, fmt,
| ~~~~~~~~~~~~~~~~~^~~~~~~~~~~
2222 | array[i]->GetNameString());
| ~~~~~~~~~~~~~~~~~~~~~~~~~~
Nope, needs proper fixing..
name = JS_sprintf_append(name, fmt,
(array[i]->GetNameString() != NULL) ? array[i]->GetNameString() : "(NULL)");
But newer versions of seamonkey exist (which made have already fixed it, didn't check).