FS#63543 - [libvirt] bash completion support not installed

Attached to Project: Community Packages
Opened by eaut (eaut) - Friday, 23 August 2019, 17:27 GMT
Last edited by freswa (frederik) - Saturday, 17 October 2020, 16:29 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Christian Rebischke (Shibumi)
Robin Broda (coderobe)
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Please add bash completion support for virsh & virt-admin to the libvirt package.
It is already part of the libvirt source code and is located in "tools/bash-completion/vsh"
This task depends upon

Closed by  freswa (frederik)
Saturday, 17 October 2020, 16:29 GMT
Reason for closing:  Works for me
Additional comments about closing:  It's included in the package.
Comment by Eli Schwartz (eschwartz) - Friday, 23 August 2019, 17:38 GMT
https://github.com/libvirt/libvirt/commit/f0d390bc161e3845554244b319e36907d40ad6ef

So they added this bash completion file, but don't install it because it uses pkg-config to check for the bash-completion package... and then it installs a filename which is not loaded, and doesn't create symlinks so it will actually be picked up? That's annoying.

The file needs to be installed to "${pkgdir}"/usr/share/bash-completion/completions/ and it needs to be installed as both "virsh" and "virt-admin" (usually using symlinks).

Ideally encourage upstream to do exactly that in their Makefile, and for them to check the bash-completion completionsdir *but fallback on the standard location*.

Loading...