Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#63502 - [docker] should bundle buildx plugin

Attached to Project: Community Packages
Opened by Pierre Carru (pierrec) - Monday, 19 August 2019, 16:08 GMT
Last edited by Sébastien Luttringer (seblu) - Thursday, 02 April 2020, 00:26 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Sébastien Luttringer (seblu)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
Private No

Details

Several docker client plugins are normally bundled with docker-ce 19.03
See https://github.com/docker/buildx#installing or https://docs.docker.com/buildx/working-with-buildx/#install


The official debian packages have them (coming from docker.com) do it:
```
dpkg -L docker-ce-cli | grep cli-plug
/usr/libexec/docker/cli-plugins
/usr/libexec/docker/cli-plugins/docker-app
/usr/libexec/docker/cli-plugins/docker-buildx
```
That's how they do it for the debian package
https://github.com/docker/docker-ce-packaging/blob/d47670e992d5776230b979c32683c384f8f0dd8c/deb/common/rules#L14

For the tarball:
https://github.com/docker/docker-ce-packaging/blob/d47670e992d5776230b979c32683c384f8f0dd8c/static/scripts/build-cli-plugins
This task depends upon

Closed by  Sébastien Luttringer (seblu)
Thursday, 02 April 2020, 00:26 GMT
Reason for closing:  Implemented
Additional comments about closing:  docker-1:19.03.8-2
Comment by Sébastien Luttringer (seblu) - Wednesday, 04 September 2019, 02:16 GMT
From the links you pointed,

Docker Buildx is included in Docker 19.03 and is also bundled with the following Docker Desktop releases. Note that you must enable the ‘Experimental features’ option to use Docker Buildx.

And,
Experimental features provide early access to future product functionality. These features are intended for testing and feedback only as they may change between releases without warning or can be removed entirely from a future release. Experimental features must not be used in production environments. Docker does not offer support for experimental features. For more information, see Experimental features.

So, why should this be added?
Comment by Pierre Carru (pierrec) - Wednesday, 04 September 2019, 07:53 GMT
I thought we would want the docker package to bundle the same features as the official one
Comment by Tom Boshoven (TBoshoven) - Friday, 06 December 2019, 13:43 GMT
The Docker documentation mentions it comes bundled so this ends up being quite confusing.
Comment by Francisco Lopes (pepper_chico) - Saturday, 18 January 2020, 07:16 GMT
Hi,

The docker documentation states it comes bundled with Docker CE (Community Edition), which is a bundle of docker stuff (not just docker), with those plugins as part of the bundle. The ArchLinux package should aim to replicate such bundle, which currently it is not doing. docker-buildx (and possibly any other plugin that comes bundled to CE) should be part of the package (currently I'm just downloading the binary release from docker-buildx repository and dropping it at /usr/local/lib/docker/cli-plugins).

cli plugin locations are described at https://github.com/docker/cli/issues/1534
Comment by Sébastien Luttringer (seblu) - Sunday, 19 January 2020, 01:55 GMT
yes, as Pierre suggested at the beginning, we should add it to mimic the bundled package.
Didn't take time to do it yet. If you have a tested PKGBUILD patch I'd be happy to merge it.
Comment by G. Richard Bellamy (rbellamy) - Tuesday, 24 March 2020, 13:52 GMT
Here's a PKGBUILD patch to bundle the cli-plugins. Works on two of my systems, which isn't great test coverage.

While the cli-plugins come bundled, none of the packages I found added the path to the plugins to $PATH. That seems to have been left up to the user.
Comment by G. Richard Bellamy (rbellamy) - Tuesday, 24 March 2020, 19:30 GMT Comment by Sébastien Luttringer (seblu) - Thursday, 02 April 2020, 00:20 GMT
The patch is very clean! Great work.

The two plugins add about 29MB to the package (from 39MB to 68MB). Almost double it.
There is also a lot of dependencies downloaded directly by go (for buildx) out of our source array.

Anyway, give it a try.

Loading...