FS#63395 - [archiso] Download script in automated_script.sh using https

Attached to Project: Release Engineering
Opened by Charles Vejnar (vejnar) - Tuesday, 06 August 2019, 19:37 GMT
Last edited by David Runge (dvzrv) - Saturday, 30 May 2020, 18:00 GMT
Task Type Bug Report
Category ArchISO
Status Closed
Assigned To David Runge (dvzrv)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Hi,

I am using a script to install Arch automatically using a "script" parameter to my start command line. It works.

However `.automated_script.sh` (in airootfs/root) only supports http to download the script and not https.

To fix it, replace line 18:
if [[ "${script}" =~ ^http:// || "${script}" =~ ^ftp:// ]]; then

By:
if [[ "${script}" =~ ^http:// || "${script}" =~ ^https:// || "${script}" =~ ^ftp:// ]]; then

Although it's a small change, I can submit a pull request if necessary. Please tell me where.

Thanks.
This task depends upon

Closed by  David Runge (dvzrv)
Saturday, 30 May 2020, 18:00 GMT
Reason for closing:  Fixed
Additional comments about closing:  Merged with https://gitlab.archlinux.org/archlinux/a rchiso/-/merge_requests/2/diffs

Will be part of v44
Comment by Gerardo Exequiel Pozzi (djgera) - Friday, 09 August 2019, 16:59 GMT
yes please.
Comment by David Runge (dvzrv) - Saturday, 23 May 2020, 14:31 GMT
@vejnar: Thanks for the report.

Necessary changes have now been applied in a merge request upstream [1] and will be available in an upcoming version of archiso.

[1] https://gitlab.archlinux.org/archlinux/archiso/-/merge_requests/2

Loading...