FS#63393 - [libmypaint] doesn't build, tries to retool with automake 1.13

Attached to Project: Arch Linux
Opened by Andreas Baumann (andreas_baumann) - Tuesday, 06 August 2019, 18:44 GMT
Last edited by Levente Polyak (anthraxx) - Tuesday, 10 September 2019, 20:38 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

checking for autoconf >= 2.62 ... yes (version 2.69)
checking for automake >= 1.13 ...
You must have automake 1.13 or newer installed to compile libmypaint.
Download the appropriate package for your distribution,
or get the source tarball at ftp://ftp.gnu.org/pub/gnu/automake/

./autogen.sh: line 150: automake-1.13: command not found
Major version might be too new (1.13)
checking for intltool >= 0.40.1 ... yes (version 0.51.0)

Please install/upgrade the missing tools and call me again.

Additional info:
* package version(s): 1.3.0-6

Steps to reproduce:
asp export libmypaint
cd libmypaint
staging-x86_64-build
This task depends upon

Closed by  Levente Polyak (anthraxx)
Tuesday, 10 September 2019, 20:38 GMT
Reason for closing:  Fixed
Additional comments about closing:  1.4.0-1
Comment by loqs (loqs) - Tuesday, 06 August 2019, 20:16 GMT
Does this patch work for you?
Adds https://github.com/mypaint/libmypaint/commit/40d9077a80be13942476f164bddfabe842ab2a45 as autogen.patch for automake 1.16
Adds changes to gegl/mypaint-gegl-surface.c from https://github.com/mypaint/libmypaint/pull/142/commits/9a68c27d9e222cfbb68fdf853adb95492421d4ee to gegl-0.4.patch for GEGL 0.4.14 API change
Edit:
update.patch is the whole diff
   autogen.patch (0.8 KiB)
   update.patch (4.2 KiB)
Comment by Andreas Baumann (andreas_baumann) - Wednesday, 07 August 2019, 03:17 GMT
Thanks a lot, yes update.patch works fine.
I applied it downstreams: https://git.archlinux32.org/archlinux32/packages/src/branch/master/extra/libmypaint
Comment by Eli Schwartz (eschwartz) - Wednesday, 07 August 2019, 04:29 GMT
The correct solution is to use autoreconf instead of the shenanigans that people get up to with version checking in autogen.sh

The following diff will make the following changes:

- switch to using autoreconf + intltoolize
- switch the gegl-0.4.patch for the upstream commits which 1) fix the pkg-config file, and 2) PR to both support gegl and modify mypaint-gegl-surface.c

BTW: if libmypaint.pc is being renamed at all, then it needs to be changed everywhere it is used rather than breaking libmypaint-gegl.pc ... but the better question is why it is being renamed at all?  FS#62468  covers this, though. If that ticket is solved by no longer breaking the pkg-config dependency name then drop patch #1 and rebase patch #2.
   libmypaint.diff (1.7 KiB)

Loading...