FS#63381 - [zathura] zsh compdef is misplaced

Attached to Project: Community Packages
Opened by Ronan Pigott (Brocellous) - Monday, 05 August 2019, 21:43 GMT
Last edited by Johannes Löthberg (demize) - Thursday, 15 August 2019, 17:29 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Johannes Löthberg (demize)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
zathura package installs the _zathura zsh compdef to /usr/share/zsh/vendor-completions/_zathura, but this is not in the default fpath for zsh.

Virtually all arch packages that ship with zsh completions install them to /usr/share/zsh/site-completions which is in the default fpath. On my system, zathura is the only installed package that does otherwise.

As a result, zathura zsh completions do not function out of the box, while most other zsh completions do. I think these completions should be moved to site-completions.
This task depends upon

Closed by  Johannes Löthberg (demize)
Thursday, 15 August 2019, 17:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  0.4.3-3
Comment by Ronan Pigott (Brocellous) - Monday, 05 August 2019, 21:44 GMT
s/site-completions/site-functions/
Comment by Eli Schwartz (eschwartz) - Monday, 05 August 2019, 22:38 GMT
$ pkgfile -vrd '/usr/share/zsh/vendor-completions/.+'
community/chezmoi 1.6.0-1 /usr/share/zsh/vendor-completions/_chezmoi
community/code 1.36.1-1 /usr/share/zsh/vendor-completions/_code
community/code 1.36.1-1 /usr/share/zsh/vendor-completions/_code-oss
community/git-annex 7.20190730-1 /usr/share/zsh/vendor-completions/_git-annex
community/sysdig 0.26.1-1 /usr/share/zsh/vendor-completions/_sysdig
community/zathura 0.4.3-2 /usr/share/zsh/vendor-completions/_zathura
Comment by Eli Schwartz (eschwartz) - Monday, 05 August 2019, 23:24 GMT
Upstream's meson.build hardcodes an install directory that exists exclusively on Debian.

By the way, why does the zathura package contain a vendored bash-completion which overwrites the one that upstream installs?
Comment by Ronan Pigott (Brocellous) - Thursday, 15 August 2019, 03:09 GMT
I convinced upstream to move their completions to site-functions: https://git.pwmt.org/pwmt/zathura/merge_requests/22 .

Now I suppose we can just remove those vendored bash-completions? They look identical to upstream's anyway.
Comment by Eli Schwartz (eschwartz) - Thursday, 15 August 2019, 14:12 GMT
Thank you for following this upstream!

I'm not sure when zathura intends to publish a new stable release, though, so it might be well worth emulating that fix in our packaging until then. Let's see what the package maintainer thinks.
Comment by Johannes Löthberg (demize) - Thursday, 15 August 2019, 17:28 GMT
Eli: Because zathura only added their bash completion a year ago, and I hadn't noticed!

Loading...