Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#63332 - [shairport-sync] metadata pipe output not supported in build

Attached to Project: Community Packages
Opened by Christoph Kreutzer (ckreutzer) - Wednesday, 31 July 2019, 19:09 GMT
Last edited by Anatol Pomozov (anatolik) - Friday, 20 September 2019, 22:26 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I'm using shairport-sync next to forked-daapd as AirPlay sink for multiroom audio from AirPlay sources like iPhones. That works pretty good as described for forked-daapd: http://ejurgensen.github.io/forked-daapd/#pipes-for-eg-multiroom-with-shairport-sync

The pipe output is already working perfectly, however the also documented metadata pipe is not created:
[root@itunes ~]# ls -al /daapd-data/music/Zuhause*
prw-r--r-- 1 shairport-sync shairport-sync 0 Jul 31 18:36 /daapd-data/music/Zuhause.AirPlay
[root@itunes ~]#

But it is configured in /etc/shairport-sync.conf:
pipe =
{
name = "/daapd-data/music/Zuhause.AirPlay";
};
metadata =
{
enabled = "yes";
include_cover_art = "yes";
pipe_name = "/daapd-data/music/Zuhause.AirPlay.metadata";
pipe_timeout = 60000;
};

According to upstream documentation (https://github.com/mikebrady/shairport-sync/blob/1dd0d828363ccc0ce41e61c36cce1c0bd6b7054a/README.md), adding the --with-metadata option to configure is required. This seems to be not present in the current PKGBUILD: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/shairport-sync&id=27a8ca37618dd85b4de8a7d72008112228bf878a

TL;DR: Would it be possible to add the --with-metadata option to configure in the PKGBUILD, or are there reasons against it? AFAIK, It needs no additional dependencies and pipe support is already built in.

Additional info:
* package version(s): 3.3.1-OpenSSL-Avahi-dns_sd-ALSA-pa-stdout-pipe-soxr-sysconfdir:/etc
* config and/or log files etc: relevant parts are already put in the description. Full is in attachment.

Steps to reproduce:
* configure metadata section in /etc/shairport-sync.conf as described (set a valid path for pipe_name)
* start shairport-sync
* no pipe is created
This task depends upon

Closed by  Anatol Pomozov (anatolik)
Friday, 20 September 2019, 22:26 GMT
Reason for closing:  Implemented
Additional comments about closing:  shairport-sync-3.3.2-2
Comment by Anatol Pomozov (anatolik) - Thursday, 19 September 2019, 21:42 GMT
Thank you for reporting the issue. There is no objection in enabling this feature.

shairport-sync-3.3.2-2 been pushed to the repo. Please verify that it works as expected.
Comment by Christoph Kreutzer (ckreutzer) - Friday, 20 September 2019, 17:56 GMT
Hello Anatol,

Looks good:
# shairport-sync --version
3.3.2-OpenSSL-Avahi-dns_sd-ALSA-pa-stdout-pipe-soxr-metadata-sysconfdir:/etc

Also seems to work fine now in my setup.

Thank you very much!

Best regards,
Christoph

Loading...