FS#63321 - [vpnc] vpnc@.service suggestions

Attached to Project: Arch Linux
Opened by Anton Karmanov (bergentroll) - Tuesday, 30 July 2019, 14:39 GMT
Last edited by Levente Polyak (anthraxx) - Wednesday, 21 August 2019, 21:10 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

It is about vpnc 1:0.5.3.r460.r73-1, vpnc@.service from trunc.

I suppose it is better to add Wants=network.target and Requires=network.target to [ Unit ] section because without network service fails on startup.

I also suggest to add Restart=always to [ Service ] section for case of crashes.
This task depends upon

Closed by  Levente Polyak (anthraxx)
Wednesday, 21 August 2019, 21:10 GMT
Reason for closing:  Implemented
Additional comments about closing:  1:0.5.3.r462.r78-1
Comment by loqs (loqs) - Tuesday, 30 July 2019, 17:29 GMT
Adding Wants=network.target and Requires=network.target does not mean a network connection will be available [1]
The service could add After=network.target which would shutdown vpnc before networking and would align with sshd.service

[1] https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/

Loading...