FS#63056 - [qt5-webkit] Builds as debug rather than release build

Attached to Project: Arch Linux
Opened by Florian Bruhin (The-Compiler) - Monday, 01 July 2019, 07:33 GMT
Last edited by Antonio Rojas (arojas) - Monday, 01 July 2019, 20:16 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To No-one
Architecture All
Severity Medium
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The update to 5.212.0-alpha3 removed "-DCMAKE_BUILD_TYPE=Release":

https://git.archlinux.org/svntogit/packages.git/commit/trunk?h=packages/qt5-webkit&id=033e90358d6f9d2fb8f28a52d0271a0c4825c798

However, that causes QtWebKit to be built as a debug build, which probably isn't intended - also see:

https://github.com/qutebrowser/qutebrowser/issues/4877#issuecomment-507067697

(Note this might also have an unknown security impact - I'm not sure how exactly a debug build behaves differently from a release one)
This task depends upon

Closed by  Antonio Rojas (arojas)
Monday, 01 July 2019, 20:16 GMT
Reason for closing:  Fixed
Additional comments about closing:  qt5-webkit 5.212.0alpha3-3
Comment by Antonio Rojas (arojas) - Monday, 01 July 2019, 08:48 GMT
What makes you think that it's being built as a debug build? make VERBOSE=1 doesn't show any debug flag.
Comment by Florian Bruhin (The-Compiler) - Monday, 01 July 2019, 11:42 GMT
The qutebrowser bug I linked above shows an assertion being triggered which wasn't triggered with the 5.212.0alpha2+212+g186f5bff107 package (probably because assertions are disabled in release builds). Also, in that issue, annulen (the upstream maintainer) says:

> Yep, without -DCMAKE_BUILD_TYPE=Release things will probably go bad

Comment by Antonio Rojas (arojas) - Monday, 01 July 2019, 12:29 GMT
OK so the problem is enabled asserts, not debug build. I could certainly disable them, but IMHO the issue should be properly fixed instead of swept under the rug - asserts are there for a reason after all

Loading...