FS#62837 - [gitlab] allow configuration of initializers in /etc/webapps/gitlab

Attached to Project: Community Packages
Opened by simonzack (simonzack) - Friday, 07 June 2019, 13:02 GMT
Last edited by Anatol Pomozov (anatolik) - Friday, 05 June 2020, 18:15 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Anatol Pomozov (anatolik)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
Can there be a way to allow configuration of initializers in /etc/webapps/gitlab/ instead of /usr/share/webapps/gitlab/config/initializers/?

If they are in /etc/, it is much easier to version control of my settings.

The particular file I'm after is smtp_settings.rb, so that I can receive emails sent from Gitlab.

Additional info:
* package version(s) gitlab 11.11.2-1
This task depends upon

Closed by  Anatol Pomozov (anatolik)
Friday, 05 June 2020, 18:15 GMT
Reason for closing:  Implemented
Additional comments about closing:  13.0.3
Comment by Sven-Hendrik Haase (Svenstaro) - Tuesday, 18 June 2019, 10:26 GMT
This is generally a good idea but I wonder what the upgrade path for users would be like since if I now delete that directory from the package, some users who might have configured some stuff there would be super unhappy. I might slap it into the backup array for a few months to give users a chance to upgrade. What do you think?
Comment by Sven-Hendrik Haase (Svenstaro) - Tuesday, 18 June 2019, 10:31 GMT
Actually speaking of which, is this actually a directory that users are supposed to be hand configuring? I've never touched any of that. It's a lot of files, too!
Comment by simonzack (simonzack) - Thursday, 27 June 2019, 07:46 GMT
Perhaps just put a message in the package upgrade? I'm not really sure how else to do that. But I only found 2 sample files in that directory that should be user-configurable, so maybe you could just backup those 2.

Maybe it'll be alright to just make those 2 sample files hand-configurable.
Comment by Phillip Stephens (antidotecrk) - Saturday, 10 August 2019, 15:30 GMT
This is related to an issue I ran into upgrading my gitlab CE instance to 12.1.4, but apparently the package includes `0_license.rb` which is only required for EE and causes gitlab to abort otherwise, could the package rename that to `0_license.rb.example` or something similar so it's not loaded by default?

Also, yes, this is a directory that is intended to be user modified, the gitlab documentation frequently mentions modifying/creating files in `config/initializers` for things like SMTP or prometheus metrics
Comment by Anatol Pomozov (anatolik) - Friday, 29 May 2020, 04:52 GMT
SVN revision 636953 adds /etc/webapps/gitlab/smtp_settings.rb configuration file that allows to configure SMTP for gitlab.

The feature will be available with the next gitlab build
Comment by simonzack (simonzack) - Friday, 29 May 2020, 06:54 GMT
Brilliant, thanks for this!

Loading...