FS#62777 - [hddtemp] Make location of configuration file consistent to the packages man page

Attached to Project: Arch Linux
Opened by Christian Schiffer (iffer) - Wednesday, 29 May 2019, 12:21 GMT
Last edited by Gaetan Bisson (vesath) - Monday, 24 February 2020, 20:04 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Gaetan Bisson (vesath)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:
When adding a new drive to my machine, I noticed, that the package's man page pointed to a non-existing configuration file '/etc/hddtemp.db'. The wiki-article revealed the location to be in '/usr/share/hddtemp/hddtemp.db'. Although hddtemp.db is not strictly a configuration file, its list of drive configurations is not well maintained and often requires amendments to deal with HDDs or SSDs. Therefore hddtemp.db is practically a configuration file and should be moved to /etc/.

Also the package didn't build, because an upstream patch wasn't extracted in the prepare section and the modified hddtemp.db file shouldn't be overwritten, when upgrading.

The attached patch fixes both issues.


Additional info:
* package version: 0.3.beta15.53-1
   PKGBUILD.diff (1.4 KiB)
This task depends upon

Closed by  Gaetan Bisson (vesath)
Monday, 24 February 2020, 20:04 GMT
Reason for closing:  Implemented
Additional comments about closing:  hddtemp-0.3.beta15.53-2 in [extra]
Comment by Gaetan Bisson (vesath) - Monday, 24 February 2020, 20:03 GMT
I've implemented your proposal with respect to the hddtemp.db file.

However makepkg has no trouble unzipping the diff file. Please make sure your build environment is clean and up-to-date if you keep experiencing issues related to that.

Cheers.

Loading...