FS#62733 - Disable "Flag out-of-date" button for VCS packages
Attached to Project:
AUR web interface
Opened by UnicornDarkness (Xorg) - Friday, 24 May 2019, 15:27 GMT
Last edited by Lukas Fleischer (lfleischer) - Saturday, 26 October 2019, 00:18 GMT
Opened by UnicornDarkness (Xorg) - Friday, 24 May 2019, 15:27 GMT
Last edited by Lukas Fleischer (lfleischer) - Saturday, 26 October 2019, 00:18 GMT
|
Details
I am not blaming specific people, but some people don't read
the wiki and don't understand how makepkg works, so they
still flag VCS packages out-of-date when they think an
update is available.
However, the wiki[1] is clear about that: "Note: VCS packages are not considered out-of-date when the pkgver changes, do not flag them as the maintainer will merely unflag the package and ignore you." So it disturbs package maintainer for nothing. And a lot a VCS packages are flagged out-of-date for nothing, see [2]. I think the "Flag out-of-date" button should be disabled for VCS packages, and if something is broken, people can still leave a comment. [1] https://wiki.archlinux.org/index.php/Arch_User_Repository#Flagging_packages_out-of-date [2] https://aur.archlinux.org/packages/?O=0&SeB=nd&K=-git&outdated=on&SB=v&SO=d&PP=50&do_Search=Go |
This task depends upon
Closed by Lukas Fleischer (lfleischer)
Saturday, 26 October 2019, 00:18 GMT
Reason for closing: Implemented
Additional comments about closing: Implemented in 4.8.0.
Saturday, 26 October 2019, 00:18 GMT
Reason for closing: Implemented
Additional comments about closing: Implemented in 4.8.0.
Or I was thinking about automatically detect if a package uses a VCS source (maybe by searching a suffix in pkgname, like -git or -svn, or by checking if pkgver() function exists in PKGBUILD). If it is a VCS package, then the "Flag out-of-date" feature will be unavailable.
But the term "unavailable" must be defined:
1. Remove the link?
2. Grey and disable the link?
3. Leave the link but redirect to a different page with a different message (e.g. "You can not flag this package out-of-date because XXX")
The last one seems more civilized: it is better if we can explain to people why they can't flag out-of-date a VCS package (e.g. invite people to read the wiki page).
Having a different page with a different message sounds good to me.
As fallback, if a package maintainer still want the "Flag out-of-date" feature (e.g. a false positive by automated detection), then he should be able to manually reactivate it.
In my opinion, such changes should not affect versioned packages: it must not be possible to disable "Flag out-of-date" feature for versioned package in any case.
Disabling OOD flags and saying "if there are real issues, use the comments", is a bit of an odd solution, because we could also say the exact same thing about stable packages that are out of date.
Users will just leave the same comments that they'd otherwise put in the out of date comment.
According to the VCS package guidelines[1], the convention for naming VCS packages is the following:
"Suffix pkgname with -cvs, -svn, -hg, -darcs, -bzr, -git etc"
I guess matching of one those 6 regex can be used to try to auto-detect VCS packages.
[1] https://wiki.archlinux.org/index.php/VCS_package_guidelines
Thank you very much Lukas for your job.
You should allow this string to be translated. :)