FS#62714 - [nmap] [7.70-3] Icon in .desktop file is hardlinked

Attached to Project: Arch Linux
Opened by Zen M (zenm) - Wednesday, 22 May 2019, 21:09 GMT
Last edited by Gaetan Bisson (vesath) - Monday, 16 September 2019, 18:26 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Gaetan Bisson (vesath)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The .desktop files in /usr/share/applications (zenmap.desktop & zenmap-root.desktop) are hardlinking the Icon property to "/usr/share/zenmap/pixmaps/zenmap.png" instead of simply writing zenmap in order to get an themed icon when you're using an icon pack. This was fixed a long time in upstream (https://github.com/nmap/nmap/blob/a0418c0b892faded3b57a4c301d6d741e3281aeb/zenmap/install_scripts/unix/zenmap.desktop) so that the misconduct occurs propably during packaging.
This task depends upon

Closed by  Gaetan Bisson (vesath)
Monday, 16 September 2019, 18:26 GMT
Reason for closing:  Upstream
Comment by Gaetan Bisson (vesath) - Wednesday, 22 May 2019, 21:27 GMT
I'm not sure what the problem is with having a desktop file with absolute paths, but if you are curious it turns out the `Icon=zenmap` line gets modified during `make install`. In nmap's main Makefile, under the install-zenmap rule, you have:

cd $(ZENMAPDIR) && $(PYTHON) setup.py --quiet install --prefix "$(prefix)" --force $(if $(DESTDIR),--root "$(DESTDIR)")

And in `zenmap/setup.py` you have a bunch of code that start with the comment:

# Rewrite the zenmap.desktop and zenmap-root.desktop files to point to
# the installed locations of the su-to-zenmap.sh script and application
# icon.

Cheers.
Comment by Zen M (zenm) - Thursday, 23 May 2019, 13:43 GMT
So this is an upstream problem and should be reported to the repository of nmap?
Comment by Gaetan Bisson (vesath) - Thursday, 23 May 2019, 17:29 GMT
Yes. (Though I'm not sure that hardcoding the path should be considered a bug per se.)

Loading...