FS#62606 - [gitlab-shell] ignores `auth_file` config
Attached to Project:
Community Packages
Opened by Vlad (ejiek) - Saturday, 11 May 2019, 17:31 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 15 June 2019, 17:51 GMT
Opened by Vlad (ejiek) - Saturday, 11 May 2019, 17:31 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Saturday, 15 June 2019, 17:51 GMT
|
Details
Description:
Ignores `auth_file` field in config file. While adding new or deleting old ssh key gitlab-shell should modify given `authorized_keys` by adding new key with corresponding command or substituting old one with # symbols. I have this file configured to default location for archlinux install: /var/lib/gitlab/.ssh/authorized_keys After adding new key I can see failed background job (ssh key info removed): Queue: gitlab_shell Job: GitlabShellWorker Arguments: "add_key", "key-x", "ssh-x xxx" Error: Errno::EACCES: Permission denied @ rb_sysopen - /home/git/.ssh/authorized_keys.lock Looks like its attempting to access file by some hardcoded path because even user is wrong (it should be gitlab) PS. Background jobs: Admin Area -> Monitoring -> Background Jobs Additional info: * 2:9.0.0-1 * `/etc/webapps/gitlab-shell/config.yml` differs from default with * gitlab_url: "http+unix://%2Fvar%2Flib%2Fgitlab%2Fsockets%2Fgitlab.socket" * migration: enabled: true wich means that `auth_file` is set to "/var/lib/gitlab/.ssh/authorized_keys" Steps to reproduce: * Add new ssh key to / Remove old from _ your user * Check that it's not in configured `authorized_keys` file. |
This task depends upon
Closed by Sven-Hendrik Haase (Svenstaro)
Saturday, 15 June 2019, 17:51 GMT
Reason for closing: No response
Saturday, 15 June 2019, 17:51 GMT
Reason for closing: No response
git 996:996
I'll try to reproduce on a new install.