FS#62591 - [gitlab-gitaley] push/pull is broken both for ssh & https

Attached to Project: Community Packages
Opened by simonzack (simonzack) - Friday, 10 May 2019, 13:54 GMT
Last edited by Sven-Hendrik Haase (Svenstaro) - Tuesday, 14 May 2019, 03:40 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sven-Hendrik Haase (Svenstaro)
Architecture All
Severity High
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
We are unable to push to repositories in gitlab due to a bug in gitlab-gitaly.
I also reported this here: https://bbs.archlinux.org/viewtopic.php?pid=1845197#p1845197

Additional info:
* package versions included local/gitlab 11.10.4-1, local/gitlab-gitaly 1.35.0-1, local/gitlab-shell 2:9.0.0-1, local/gitlab-workhorse 8.6.0-1

Steps to reproduce:

When pushing a repository to gitlab using ssh or https the following is shown:

<code>
git.exe push --progress "arch" master

Counting objects: 66, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (66/66), done.
Writing objects: 100% (66/66), 8.45 KiB | 0 bytes/s, done.
Total 66 (delta 38), reused 0 (delta 0)
remote: /usr/bin/env: 'ruby': No such file or directory
To gitlab.arch:root/todo.git
! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'gitlab@gitlab.arch:root/todo.git'


git did not exit cleanly (exit code 1) (1092 ms @ 10/05/2019 9:49:42 PM)
</code>

Fix:

Finding doing <code>ln /usr/bin/ruby-2.5 /usr/bin/ruby</code> fixed the bug, I did some investigation and found that the following files began with <code>#!/usr/bin/env ruby</code> instead of <code>#!/usr/bin/env ruby-2.5</code>


* /usr/share/webapps/gitlab-gitaly/ruby/gitlab-shell/bin/test-logger
* /usr/share/webapps/gitlab-gitaly/ruby/gitlab-shell/bin/check
* /usr/share/webapps/gitlab-gitaly/ruby/gitlab-shell/hooks/post-receive
* /usr/share/webapps/gitlab-gitaly/ruby/gitlab-shell/hooks/update
* /usr/share/webapps/gitlab-gitaly/ruby/gitlab-shell/hooks/pre-receive

Changing the last 3 to start with <code>#!/usr/bin/env ruby-2.5</code> fixed the issue.
This task depends upon

Closed by  Sven-Hendrik Haase (Svenstaro)
Tuesday, 14 May 2019, 03:40 GMT
Reason for closing:  Fixed
Comment by Sven-Hendrik Haase (Svenstaro) - Monday, 13 May 2019, 17:19 GMT
Please check 1.42.0.
Comment by simonzack (simonzack) - Tuesday, 14 May 2019, 02:38 GMT
Thanks appears to work now.

Loading...