FS#62203 - [uucp] Shell scripts ought to use "$@" instead of $*

Attached to Project: Community Packages
Opened by Klaus Alexander Seistrup (kseistrup) - Monday, 01 April 2019, 09:02 GMT
Last edited by Sergej Pupykin (sergej) - Friday, 17 May 2019, 15:35 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To Sergej Pupykin (sergej)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

The wrapper scripts uusched and uuto both use unquoted $* when exec'ing into uucico and uucp respectively. To avoid whitespace problems, globbing and word splitting, it would be prudent to use "$@" instead:

/usr/bin/uusched:
exec /usr/bin/uucico -r1 "$@"

/usr/bin/uuto:
exec /usr/bin/uucp -t -R -c "$@"

Steps to reproduce:

$ shellcheck /usr/bin/uusched
$ shellcheck /usr/bin/uuto
This task depends upon

Closed by  Sergej Pupykin (sergej)
Friday, 17 May 2019, 15:35 GMT
Reason for closing:  Fixed

Loading...