FS#62124 - [gimp] optdepends needs gvfs

Attached to Project: Arch Linux
Opened by Adam Fontenot (amfontenot) - Sunday, 24 March 2019, 00:42 GMT
Last edited by Christian Hesse (eworm) - Thursday, 05 May 2022, 19:48 GMT
Task Type Bug Report
Category Packages: Extra
Status Closed
Assigned To Christian Hesse (eworm)
Levente Polyak (anthraxx)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

gvfs package isn't in optdepends. Without gvfs, trying to open an image via File > Open Location fails with an error saying the location can't be mounted. After installing gvfs, it works as expected.

Additional info:
* gimp 2.10.8-1
* gvfs 1.40.0-1

As of Gimp 2.6, providing --without-gvfs when compiling would cause Gimp to fall back on other methods for downloading files. I was unable to determine from their documentation whether this is still the case. So two potential alternatives are (1) using --without-gvfs, or (2) adding a hard dependency on gvfs to make sure this function is working for all users.
This task depends upon

Closed by  Christian Hesse (eworm)
Thursday, 05 May 2022, 19:48 GMT
Reason for closing:  Fixed
Additional comments about closing:  gimp 2.10.30-3
Comment by Adam Fontenot (amfontenot) - Sunday, 13 September 2020, 19:33 GMT
#bugwranglingday

This bug is still valid. I removed gvfs and that broke remote image loading. gvfs still isn't in optdepends, and that's all it would take to fix this bug... (or just add it to depends, maybe, if this is considered core functionality by GIMP).
Comment by mattia (nTia89) - Sunday, 20 March 2022, 09:40 GMT
I cannot reproduce the issue. Is it still valid for you?
Comment by Adam Fontenot (amfontenot) - Monday, 21 March 2022, 00:02 GMT
@nTia89

Yes, the issue still exists for me. If I don't have the gvfs package installed, Gimp hangs when trying to open links from the web via File > Open Location. Actually, it seems to just hang for me. Perhaps Gimp also tries other methods for opening links, and you have one of those installed? In that case, an optdepends would still be needed here.
Comment by mattia (nTia89) - Monday, 21 March 2022, 16:57 GMT
ok... Now I see the problem!

Step to reproduce the issue:
- open GIMP
- open a remote image via "File > Open Location" (e.g. [https://upload.wikimedia.org/wikipedia/en/a/a9/Example.jpg?20070224000419])
- when you press "Open", nothing happens

(and running with "--verbose" switch via terminal, you get these two messages):
file_open_image: mounting remote volume failed, trying to downloadthe file: volume doesn’t implement mount
file_open_image: mounting remote volume failed, trying to downloadthe file: volume doesn’t implement mount

* The REAL problem is another: GIMP does not list `gvfs` as dependency [https://gitlab.gnome.org/GNOME/gimp/blob/gimp-2-10/INSTALL.in]; in fact, we do not have it (neither as optional)

** I suggest you to open a bug upstream [https://gitlab.gnome.org/GNOME/gimp/-/issues]
Comment by Adam Fontenot (amfontenot) - Tuesday, 22 March 2022, 03:38 GMT
https://gitlab.gnome.org/GNOME/gimp/-/issues/8005

Unless the GIMP folks decide to remove gvfs as a dependency, we'll probably end up needing to add it anyway.
Comment by Adam Fontenot (amfontenot) - Tuesday, 22 March 2022, 16:20 GMT
Okay, so I've got some feedback from the GIMP developers. They're saying (as I originally indicated) that GIMP has no hard dependency on GVFS. Rather, the system needs to make GIO modules available to open whatever protocols (and URI types) the user wants to be able to open.

HTTP is obviously a core one. In fact, I found that the built in help (which you can open with F1) doesn't work without GVFS installed. I think that's a good case for us to make GVFS a hard dependency, since GIMP obviously anticipates a method for opening HTTP to be available.

On the other hand, if the error messages in GIMP are made clear enough, making it an optdepend might be sufficient for Arch. Either way, it's clear the status quo isn't desirable.
Comment by mattia (nTia89) - Tuesday, 22 March 2022, 17:00 GMT
We are on the right path!

GIO is in fact in a *real* dependency (look for "GIO" in the INSTALL.in)

In this case, I don't see any drawback in adding `gvfs` as (optional?) dep here...
(Even if not all will be happy about it, because it drags a bunch of further packages away...)
Comment by Adam Fontenot (amfontenot) - Wednesday, 30 March 2022, 06:45 GMT
Update: GIMP have added a note about this to their installation notes, clarifying that a GIO handler for http and https is considered mandatory: https://gitlab.gnome.org/GNOME/gimp/-/commit/83434f72236186059414dbdca0f03c92527e2688

So if a maintainer for this package can take the 30 seconds to add it to the dependencies, we can close this. :-)
Comment by Christian Hesse (eworm) - Wednesday, 30 March 2022, 09:13 GMT
Committed to SVN. Is everybody fine if this is available in next version or do we need a rebuild?
Comment by WorMzy Tykashi (WorMzy) - Saturday, 02 April 2022, 01:39 GMT
Pulls in unnecessary (and unwanted) gtk3 packages dependencies.

Please consider making gvfs an optional, rather than hard, dependency.
Comment by Gerardo Exequiel Pozzi (djgera) - Saturday, 02 April 2022, 01:42 GMT
> Please consider making gvfs an optional, rather than hard, dependency.
+1.

Having gvfs, makes at least having undesirable Things. Like Trash, shows more devices in panel, spin-up disks (even when volume management is disabled)
Comment by somini (_somini_) - Sunday, 03 April 2022, 21:55 GMT
> Please consider making gvfs an optional, rather than hard, dependency.

+1 on this, gvfs brings too much baggage. I think it's acceptable to put it on optdepends with a scary message, and mention it on the wiki that gvfs is sort of required.
Comment by maderios (maderios) - Wednesday, 04 May 2022, 09:10 GMT
As Gimp dev says, 'gvfs' is *not* a direct Gimp dependency for *Linux*:
https://gitlab.gnome.org/GNOME/gimp/-/commit/83434f72236186059414dbdca0f03c92527e2688
"It's *not* a direct dependency and doesn't prevent GIMP from any of its
core logics, but HTTP is a used enough format nowadays that we want to
consider it as mandatory nowadays.
From what I know, `gvfs` might be for *Windows* only though. This would
explain issues we have with remote URL on other platforms."
Please remove gvfs dependency

Loading...