FS#62100 - [terminator] Colors are too dim.

Attached to Project: Community Packages
Opened by Søren Holm (sgh) - Thursday, 21 March 2019, 06:24 GMT
Last edited by Giancarlo Razzolini (grazzolini) - Sunday, 27 December 2020, 21:50 GMT
Task Type Support Request
Category Packages
Status Closed
Assigned To Jan Alexander Steffens (heftig)
Giancarlo Razzolini (grazzolini)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

In terminator 1.91-6 the colors are too dim compared to other terminals (fx. konsole)

This is something that has happened recently - within the last week or so.

Deleting .config/terminator does not fix the issue.
The content of $LS_COLORS are the same in both in konsole and terminator.
This task depends upon

Closed by  Giancarlo Razzolini (grazzolini)
Sunday, 27 December 2020, 21:50 GMT
Reason for closing:  Fixed
Comment by Giancarlo Razzolini (grazzolini) - Thursday, 21 March 2019, 13:50 GMT
Can you please send a screenshot of this issue? Also, can you please tell me on which DE/WM are you running terminator on?
Comment by P.H. (Vain) - Thursday, 21 March 2019, 15:20 GMT
VTE changed their default for "bold is bright": Previously, the escape sequence "\e[1m" changed to a bold font *and* a brighter color. This is no longer true, it now only changes to a bold font. This results in some color schemes looking a bit off.

VTE's API provides a function to customize this: "vte_terminal_set_bold_is_bright()". If this function is exposed in Terminator's UI, try setting it to "True".

Upstream discussion and commit:

https://bugzilla.gnome.org/show_bug.cgi?id=762247#c25
https://gitlab.gnome.org/GNOME/vte/commit/ab5161c7df07e09bc7796812d6fa6fdf79f61830
Comment by Søren Holm (sgh) - Saturday, 23 March 2019, 19:55 GMT
Great catch !!

Rolling back to https://archive.archlinux.org/packages/v/vte3/vte3-0.54.3-1-x86_64.pkg.tar.xz brings things back to normal. Can we patch in a call to vte_terminal_set_bold_is_bright?
Comment by Søren Holm (sgh) - Saturday, 23 March 2019, 22:25 GMT
This patch works - could we apply it and pass it upstream?
   002-bold-is-bright.path (0.5 KiB)
Comment by Giancarlo Razzolini (grazzolini) - Monday, 25 March 2019, 17:14 GMT
I have included heftig on this discussion, since I'm not the maintainer for vte3. I was not affected by this issue, and I was not able to reproduce it yet. But, since this is vte3 related, I think it would be better to open a bug for it and attach the patch.
Comment by Jan Alexander Steffens (heftig) - Monday, 25 March 2019, 17:58 GMT
That patch is for Terminator, not VTE.

It's possible that VTE's defaults regarding bold-is-bright changed.
Comment by Søren Holm (sgh) - Monday, 25 March 2019, 19:05 GMT
Let me rephrase :

This bug report is against terminator. And you are right that VTE has changed it's defaults.

Can we add the patch to terminator and pass it upstream? When some - maybe better - solution comes back from the terminator maintainer we can drop the patch.
Comment by Giancarlo Razzolini (grazzolini) - Monday, 25 March 2019, 19:40 GMT
Ok. In this case, it would be better to open a bug report upstream. I can patch it for now, provided that we have upstream bug acknowledgement.
Comment by Søren Holm (sgh) - Monday, 25 March 2019, 20:15 GMT
Excellent - I've reported the bug here : https://bugs.launchpad.net/terminator/+bug/1821636
Comment by Jakub Lansky (lenny) - Thursday, 02 May 2019, 06:59 GMT
That bug is already ack'ed by upstream for long time
https://bugs.launchpad.net/terminator/+bug/1820544
Comment by Søren Holm (sgh) - Monday, 20 April 2020, 18:46 GMT
It's still a problem - I wonder what is happening.
Comment by Giancarlo Razzolini (grazzolini) - Monday, 20 April 2020, 18:59 GMT
I have just pushed 1.92 to the repos. Can you give it a try with it as well? I can't reproduce it here.
Comment by Søren Holm (sgh) - Wednesday, 02 December 2020, 11:29 GMT
This is still a problem in the latest version.
Comment by Steve Ward (planet36) - Sunday, 27 December 2020, 02:44 GMT
It was fixed here
https://github.com/gnome-terminator/terminator/issues/38

Loading...