FS#62092 - [makepkg] wrong default hg branch

Attached to Project: Pacman
Opened by Patrik Bachan (diggit) - Wednesday, 20 March 2019, 21:39 GMT
Last edited by Allan McRae (Allan) - Friday, 11 October 2019, 10:24 GMT
Task Type Bug Report
Category makepkg
Status Closed
Assigned To Eli Schwartz (eschwartz)
Architecture All
Severity Low
Priority Normal
Reported Version 5.1.2
Due in Version 5.2.0
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Summary and Info:
makepkg fails to select correct default branch with hg

Steps to Reproduce:
Problem occurred with repo:hyOzd@bitbucket.org/hyOzd/serialplot"> https://hyOzd@bitbucket.org/hyOzd/serialplot
When cloning manually, auto selected branch is one called "default", that is correct.
Using PKGBUILD with:
source=('hg+https://bitbucket.org/hyOzd/serialplot')
auto selected branch is one called "reader-stat" which is not default one. (but most recently changed - https://bitbucket.org/hyOzd/serialplot/branches/)
This task depends upon

Closed by  Allan McRae (Allan)
Friday, 11 October 2019, 10:24 GMT
Reason for closing:  Fixed
Additional comments about closing:  git commit a8b3d1a6
Comment by Eli Schwartz (eschwartz) - Wednesday, 20 March 2019, 23:01 GMT
If I understand correctly, the default cloneable ref is either "default", or, if it exists, the bookmark "@". Yes?

hg seems to enforce the use of "default", which is contrary to the way git does not enforce "master". With git, we simply look up the symbolic "HEAD" ref, which in a bare clone matches upstream's default branch. With hg, I guess we'll need to check for the existence of the "@" bookmark first.

Since I'm not really familiar with the way hg works, I'd appreciate confirmation before I submit a patch to implement this change.
Comment by Eli Schwartz (eschwartz) - Monday, 01 April 2019, 01:04 GMT
Patrik, I've tried to implement this via the following patch: https://lists.archlinux.org/pipermail/pacman-dev/2019-March/023311.html

Can you please confirm it fixes the issue for you?

Loading...