Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#62041 - [prometheus-node-exporter] Include version in build flags

Attached to Project: Arch Linux
Opened by Daenney (daenney) - Sunday, 17 March 2019, 12:25 GMT
Last edited by Johannes Löthberg (demize) - Wednesday, 24 April 2019, 21:26 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To Jelle van der Waa (jelly)
Johannes Löthberg (demize)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The node exporter is built without passing in the version of the package as a build flag. This means `--version` returns `node_exporter, version (branch: , revision: )` and the `version` label is missing from the `node_exporter_build_info` timeseries which is often used to monitor which versions of the node exporter are deployed.

This should be fixable by passing an ldflag of `-X github.com/prometheus/common/version.Version="$pkgver"` during `go build`.
This task depends upon

Closed by  Johannes Löthberg (demize)
Wednesday, 24 April 2019, 21:26 GMT
Reason for closing:  Fixed
Additional comments about closing:  0.17.0-3
Comment by Johannes Löthberg (demize) - Wednesday, 24 April 2019, 21:26 GMT
Ugh. This applies to the rest of the prometheus packages as well, but fixed in prometheus-node-exporter so far.

Loading...