FS#61918 - [c-ares] package does not install the c-ares-config.cmake
Attached to Project:
Arch Linux
Opened by Slava (Slavas) - Tuesday, 05 March 2019, 12:47 GMT
Last edited by David Runge (dvzrv) - Sunday, 07 February 2021, 16:24 GMT
Opened by Slava (Slavas) - Tuesday, 05 March 2019, 12:47 GMT
Last edited by David Runge (dvzrv) - Sunday, 07 February 2021, 16:24 GMT
|
Details
Description:
The library provides a c-ares-config.cmake which is required for linking to this lib from projects using CMake. To have this file installed the library needs to be built with CMake. However the package sticks to using autotools build and thus no configs are installed. Additional info: * package version(s) 1.15.0-1 * config and/or log files etc. * link to upstream bug report, if any Steps to reproduce: add 'find_package(c-ares)' to CMakeLists.txt and see it not found. |
This task depends upon
Closed by David Runge (dvzrv)
Sunday, 07 February 2021, 16:24 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed with c-ares 1.17.1-1
Sunday, 07 February 2021, 16:24 GMT
Reason for closing: Fixed
Additional comments about closing: Fixed with c-ares 1.17.1-1
Comment by
Eli Schwartz (eschwartz) - Tuesday,
10 December 2019, 19:42 GMT
Comment by
Guillaume Horel (thrasibule) -
Wednesday, 02 September 2020, 18:27 GMT
Comment by
Laurențiu Nicola (lnicola) -
Thursday, 04 February 2021, 18:58 GMT
Given that the c-ares package installs a pkg-config file, it seems
prudent to not depend on a .cmake file which may or may not be
available depending on how the project was built, and instead use
find_package(FindPkgConfig) and acquire the necessary link
dependency using that (build system agnostic) method.
By building the package with cmake instead of autoconf, the
library will provide both the pkg-config file and the cmake file,
which seems like a strict improvement for cmake based projects.
See
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=c-ares-cmake
for an example.
This was done in
https://github.com/archlinux/svntogit-packages/commit/62694c663e125359b58a89367c8830c28c3312f2#diff-3e341d2d9c67be01819b25b25d5e53ea3cdf3a38d28846cda85a195eb9b7203a.