FS#61870 - [webkit2gtk] Remove unnecessary geoclue2 dependency

Attached to Project: Arch Linux
Opened by Peter Wu (Lekensteyn) - Tuesday, 26 February 2019, 22:07 GMT
Last edited by Jan Alexander Steffens (heftig) - Tuesday, 26 February 2019, 23:38 GMT
Task Type General Gripe
Category Packages: Extra
Status Closed
Assigned To Jan de Groot (JGC)
Jan Alexander Steffens (heftig)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:
webkit2gtk seems to have a build depends on geoclue2, but it is optional at runtime. It does not link against it and instead queries dbus (and gracefully fails if unavailable).

$ files=$(pacman -Ql webkit2gtk | cut -d' ' -f2- | grep -vE '^/usr/(include|share|lib/.*/)|/$|\.so(\.[0-9]+)?$')
$ ls -ld $files
-rwxr-xr-x 1 root root 887040 Feb 9 20:34 /usr/bin/WebKitWebDriver
-rwxr-xr-x 1 root root 215272 Feb 9 20:34 /usr/lib/jsc
-rwxr-xr-x 1 root root 19012048 Feb 9 20:34 /usr/lib/libjavascriptcoregtk-4.0.so.18.11.7
-rwxr-xr-x 1 root root 46309464 Feb 9 20:34 /usr/lib/libwebkit2gtk-4.0.so.37.33.7
-rwxr-xr-x 1 root root 6200 Feb 9 20:34 /usr/lib/WebKitNetworkProcess
-rwxr-xr-x 1 root root 6200 Feb 9 20:34 /usr/lib/WebKitPluginProcess
-rwxr-xr-x 1 root root 47155720 Feb 9 20:34 /usr/lib/WebKitPluginProcess2
-rwxr-xr-x 1 root root 6200 Feb 9 20:34 /usr/lib/WebKitStorageProcess
-rwxr-xr-x 1 root root 6200 Feb 9 20:34 /usr/lib/WebKitWebProcess
$ ldd $files | grep geoclue
$

https://github.com/WebKit/webkit/search?q=geoclue
https://github.com/WebKit/webkit/blob/07fabb02d73d9a774c663b39ae08dc0417e00fb3/Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.cpp#L132

Affected version:
* webkit2gtk 2.22.6-1
This task depends upon

Closed by  Jan Alexander Steffens (heftig)
Tuesday, 26 February 2019, 23:38 GMT
Reason for closing:  Implemented
Additional comments about closing:  Fixed in trunk; thanks.
Comment by Eli Schwartz (eschwartz) - Tuesday, 26 February 2019, 23:31 GMT
$ files=$(pacman -Ql webkit2gtk | cut -d' ' -f2- | grep -vE '^/usr/(include|share|lib/.*/)|/$|\.so(\.[0-9]+)?$')

I suggest you use pacman -Qql instead of ugly things with piping to cut, BTW.

Loading...