Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#61861 - [systemd] prepare() fails when called more than once

Attached to Project: Arch Linux
Opened by Justin Capella (justincapella) - Monday, 25 February 2019, 20:54 GMT
Last edited by Toolybird (Toolybird) - Monday, 25 September 2023, 08:09 GMT
Task Type General Gripe
Category Packages: Core
Status Closed
Assigned To Dave Reisner (falconindy)
Christian Hesse (eworm)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Description:


Additional info:
* package version(s) 241.7
* config and/or log files etc.
* link to upstream bug report, if any

Steps to reproduce:

makepkg -s
makepkg -c || makepkg -s || echo anything that calls prepare() again

error on: git remote add -f upstream ../systemd

Seems hacky to me to cherry pick like this, but I'm going to assume you guys know what you're doing and have good reasons.

but perhaps change to

git remote add -f upstream ../systemd || :

or add some conditional?...
This task depends upon

Closed by  Toolybird (Toolybird)
Monday, 25 September 2023, 08:09 GMT
Reason for closing:  Won't fix
Additional comments about closing:  We only support building official repo pkgs inside a clean chroot anyway.
Comment by Eli Schwartz (eschwartz) - Monday, 25 February 2019, 21:30 GMT
What is this about *package* failing?
Comment by loqs (loqs) - Monday, 25 February 2019, 21:36 GMT
makepkg -s so src/systemd is not removed
makepkg -c starts with src/systemd containing a git repo which already has a remote called upstream
git remote add -f upstream ../systemd
fatal: remote upstream already exists.
Comment by Justin Capella (justincapella) - Tuesday, 26 February 2019, 06:40 GMT
Yes, sorry, package was erroneous, meant prepare()
Comment by Eli Schwartz (eschwartz) - Tuesday, 26 February 2019, 17:08 GMT
  • Field changed: Task Type (Bug Report → General Gripe)
  • Field changed: Summary ([systemd] package() fails when called more than once → [systemd] prepare() fails when called more than once)
  • Field changed: Status (Unconfirmed → Assigned)
  • Task assigned to Dave Reisner (falconindy), Christian Hesse (eworm)
Okay.

Actually I don't quite understand what any of this does -- but plainly it breaks the ability to build when not using makepkg -C and the srcdir is already populated. That's not strictly a bug, but it is a "this would be quite nice to avoid" IMO.
Comment by loqs (loqs) - Tuesday, 26 February 2019, 17:13 GMT
From my perspective it is the same as you can not apply a patch twice so do not execute the prepare function more than once use -C to startover or -e to skip it.
Comment by Eli Schwartz (eschwartz) - Tuesday, 26 February 2019, 18:17 GMT
Except that patches usually *can* be reapplied, when the source extraction overwrites the patched version with the unpatched version.
Comment by Justin Capella (justincapella) - Monday, 04 March 2019, 05:36 GMT
Agreed it's not strictly a bug. I didn't know of about other place to suggest. The || : is or nop. Basically just to suppress the error / exit code of git remote. I wonder though if an additional source could be added instead, I feel like it might be more proper/semantic. Then make pkg -o would more accurately reflect the source about other considerations like the pkg checksums I am not currently looking at the pkgbuild so forgive me if it's a bad idea
Comment by Buggy McBugFace (bugbot) - Tuesday, 08 August 2023, 19:11 GMT
This is an automated comment as this bug is open for more then 2 years. Please reply if you still experience this bug otherwise this issue will be closed after 1 month.

Loading...