Community Packages

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#61691 - [code] 1.31 is based on Electron 3

Attached to Project: Community Packages
Opened by Arkadiy Illarionov (qarkai) - Saturday, 09 February 2019, 15:07 GMT
Last edited by Eli Schwartz (eschwartz) - Wednesday, 13 February 2019, 19:02 GMT
Task Type Feature Request
Category Packages
Status Closed
Assigned To Filipe Laíns (FFY00)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 2
Private No

Details

This task depends upon

Closed by  Eli Schwartz (eschwartz)
Wednesday, 13 February 2019, 19:02 GMT
Reason for closing:  Fixed
Additional comments about closing:  code 1.31.0-2
Comment by Arkadiy Illarionov (qarkai) - Saturday, 09 February 2019, 15:14 GMT
Also probably worth update nodejs version to nodejs-lts-dubnium.
Comment by Aidan Dang (AidanGG) - Monday, 11 February 2019, 06:36 GMT
Editing electron2 -> electron in the PKGBUILD and code.sh appears to build and work fine.

@qarkal, I tried building with dubnium, but it would not work since commit 693673bed1cc91d261d615e7639c6b239be423ea is not included in the current release. It is just a makedepends though, so we just have to wait for the next release to upgrade to dubnium.
Comment by Arkadiy Illarionov (qarkai) - Monday, 11 February 2019, 06:50 GMT
@AidanGG I'm ok with current Node.js. I wrongly assumed that since vscode uses Node.js 10 from Electron 3 it should be built on the same version.
Comment by Filipe Laíns (FFY00) - Monday, 11 February 2019, 21:25 GMT
Only node 8 is suported.

https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites
Comment by Filipe Laíns (FFY00) - Monday, 11 February 2019, 22:18 GMT
I tried rebuilding 4 times with electron instead of electron2. It doesn't seem to be stable at all for the last release.
Comment by Aidan Dang (AidanGG) - Tuesday, 12 February 2019, 02:22 GMT
Hello Filipe, I have attached my modified PKGBUILD and code.sh that work for me when built in a clean chroot (using extra-x86_64-build).
   code.sh (0.1 KiB)
   PKGBUILD (4.6 KiB)
Comment by Eli Schwartz (eschwartz) - Tuesday, 12 February 2019, 20:54 GMT
FFY00, what isn't stable about it?

OTOH, the electron2 version doesn't seem to be stable either, see https://github.com/Microsoft/vscode/issues/68354

Since VSCode upstream does NOT support electron 2.x at all, I would think this is much less stable than whichever bugs you are alluding to which would presumably affect all VSCode installations everywhere and thus merit an upstream bug report.
Comment by Filipe Laíns (FFY00) - Tuesday, 12 February 2019, 21:06 GMT
I tried to build it 4 times, none worked. Trying to rebuild a 5th time.
Comment by Eli Schwartz (eschwartz) - Wednesday, 13 February 2019, 05:04 GMT
Oh, a build issue. :/

Those always seem to build according to the whims of the RNG.
Comment by Eli Schwartz (eschwartz) - Wednesday, 13 February 2019, 19:01 GMT
I've been able to successfully build it, will shortly be available in [community].

Loading...