FS#61585 - [go] go test all fails as the testsuite is not packaged

Attached to Project: Community Packages
Opened by Allen Li (darkfeline) - Wednesday, 30 January 2019, 22:18 GMT
Last edited by Morten Linderud (Foxboron) - Tuesday, 03 September 2019, 20:19 GMT
Task Type Bug Report
Category Upstream Bugs
Status Closed
Assigned To Bartłomiej Piotrowski (Barthalion)
Morten Linderud (Foxboron)
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description: go needs to include the test subdir for the stdlib tests to pass, such as when running go test all.


Additional info:

For reference: https://github.com/golang/go/issues/29713


Steps to reproduce:
This task depends upon

Closed by  Morten Linderud (Foxboron)
Tuesday, 03 September 2019, 20:19 GMT
Reason for closing:  Implemented
Comment by Eli Schwartz (eschwartz) - Wednesday, 30 January 2019, 22:34 GMT
  • Field changed: Summary ([go] PLEASE ENTER SUMMARY → [go] go test tests the stdlib by default, but the testsuite is not packaged)
  • Field changed: Status (Unconfirmed → Assigned)
  • Field changed: Category (Packages → Upstream Bugs)
  • Task assigned to Bartłomiej Piotrowski (Barthalion), Morten Linderud (Foxboron)
Unsure if we "should" be doing anything here. Upstream is discussing whether it even makes sense to run stdlib tests by default.

Assigning, to get the package maintainers' perspectives on this.

(Please remember to fill in useful bug summaries.)
Comment by Allen Li (darkfeline) - Thursday, 31 January 2019, 05:21 GMT
Sorry, I missed the summary field in the initial form, and I was unable to change it after submitting.

My interpretation of the current discussion is that users should expect to need everything included in the official Go distribution. So long as the official Go distribution includes the test/ subdir, we should be including it also. There may be "lite" Go distributions without the test/ subdir, in which case if Arch decides to base the go package off one of these "lite" distributions, we would not be getting the test/ subdir.

(My understanding of the Arch philosophy is that the community version of go would keep being the full Go distribution, and any "lite" Go distribution would be relegated to the AUR.)
Comment by Morten Linderud (Foxboron) - Thursday, 31 January 2019, 10:38 GMT
I pushed an update yesterday to fix the issue. `-3` should have the test directory included.
Comment by Allen Li (darkfeline) - Friday, 01 February 2019, 05:06 GMT
Thanks

Loading...