Arch Linux

Please read this before reporting a bug:
https://wiki.archlinux.org/title/Bug_reporting_guidelines

Do NOT report bugs when a package is just outdated, or it is in the AUR. Use the 'flag out of date' link on the package page, or the Mailing List.

REPEAT: Do NOT report bugs for outdated packages!
Tasklist

FS#61567 - [efitools] Build from signed tags

Attached to Project: Arch Linux
Opened by Jonas Witschel (diabonas) - Tuesday, 29 January 2019, 14:45 GMT
Last edited by David Runge (dvzrv) - Monday, 25 May 2020, 15:20 GMT
Task Type Feature Request
Category Packages: Extra
Status Closed
Assigned To David Runge (dvzrv)
Architecture All
Severity Very Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I noticed that upstream offers signed tags of the form "v${pkgver}", which could be used for building. They are signed by project maintainer James Bottomley, key fingerprint: D5606E73C8B46271BEAD9ADF814AE47C214854D6.

Some other minor points:
- In my understanding, the entry in the license array should be 'GPL2' instead of 'GPL' because the code is explicitly licensed under version 2: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/efitools.git/tree/COPYING
- The URL could be updated to the new location https://git.kernel.org/pub/scm/linux/kernel/git/jejb/efitools.git (there is an automatic redirect from the old URL in place though).
- I don't think the custom "options" array is necessary: I tested the EFI binaries compiled without these options on multiple machines, and they worked fine.

Attached is a patch to the PKGBUILD that incorporates these changes, as well as updating the package to the latest version 1.9.2.

While building this package with parallel jobs, I noticed occasional build failures. As the reason for that I identified a wrong prerequisite in Make.rules. If this is a concern, I also attach the patch I sent upstream yesterday (2019-01-28) to fix it.

Additional info:
* efitools 1.8.1-1
   efitools-1.9.2-1_PKGBUILD.diff (1.1 KiB)
   Make.rules-use-correct-prereq... (0.9 KiB)
This task depends upon

Closed by  David Runge (dvzrv)
Monday, 25 May 2020, 15:20 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with 1.9.2-3
Comment by Jonas Witschel (diabonas) - Saturday, 02 February 2019, 15:15 GMT
Regarding the custom options array: this is in fact completely unnecessary because makepkg doesn't even strip EFI binaries, and the "normal" ELF files work fine when they are stripped, as is expected.

Loading...