FS#61502 - Wrong path to PID in systemd service file

Attached to Project: Community Packages
Opened by Stephan Huiser (huiser) - Tuesday, 22 January 2019, 13:40 GMT
Last edited by Eli Schwartz (eschwartz) - Tuesday, 22 January 2019, 20:44 GMT
Task Type Bug Report
Category Packages
Status Closed
Assigned To No-one
Architecture All
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Description:

From journal:
jan 22 14:35:05 myhostname systemd[1]: /usr/lib/systemd/system/glusterd.service:8: PIDFile= references path below legacy directory /var/run/, updating /var/run/glusterd.pid → /run/glusterd.pid; please update the unit file accordingly.


Additional info:
* package version: 1:5.2-2

Steps to fix:

Change /usr/lib/systemd/system/glusterd.service:

PIDFile=/run/glusterd.pid
This task depends upon

Closed by  Eli Schwartz (eschwartz)
Tuesday, 22 January 2019, 20:44 GMT
Reason for closing:  Upstream
Additional comments about closing:  Please discuss with upstream in order to fix their service file and solve the *warning*.
Comment by Dave Reisner (falconindy) - Tuesday, 22 January 2019, 13:48 GMT
The unit comes from upstream:

https://github.com/gluster/glusterfs/blob/master/extras/systemd/glustereventsd.service.in

Yes, it's configurable, but it really should be hardcoded to /run, not @localstatedir@/run.
Comment by Eli Schwartz (eschwartz) - Tuesday, 22 January 2019, 20:43 GMT
It is not configurable. localstatedir is also used as:

1) a cpp macro -DDATADIR in order to set the location for DATADIR"/db/glusterd/" and DATADIR"/lib/glusterd/" and DATADIR"/log/glusterfs/"

2) "@localstatedir@/log/glusterfs" in a couple of *.in files

It doesn't seem at all safe to cheat the system and define localstatedir as /

...

Anyway, it doesn't make sense to apply downstream patches just to get rid of a warning, please discuss this with upstream.

Loading...